From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmfqB-0001wk-Dd for qemu-devel@nongnu.org; Thu, 05 Jul 2012 02:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Smfq5-0001Sh-Bl for qemu-devel@nongnu.org; Thu, 05 Jul 2012 02:47:02 -0400 Received: from mout.web.de ([212.227.15.4]:54889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smfq5-0001SP-2G for qemu-devel@nongnu.org; Thu, 05 Jul 2012 02:46:57 -0400 Message-ID: <4FF53856.6030901@web.de> Date: Thu, 05 Jul 2012 08:46:46 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1341454689-8129-1-git-send-email-qemulist@gmail.com> In-Reply-To: <1341454689-8129-1-git-send-email-qemulist@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigEAE41F9754D45456A580811C" Subject: Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Ping Fan Cc: qemu-devel@nongnu.org, Anthony Liguori , kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEAE41F9754D45456A580811C Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-07-05 04:18, Liu Ping Fan wrote: > Vcpu state must be set completely before receiving INIT-IPI,SIPI >=20 > Signed-off-by: Liu Ping Fan > --- > kvm.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) >=20 > diff --git a/kvm.h b/kvm.h > index 9c7b0ea..5b3c228 100644 > --- a/kvm.h > +++ b/kvm.h > @@ -198,6 +198,7 @@ static inline void cpu_synchronize_post_init(CPUArc= hState *env) > { > if (kvm_enabled()) { > kvm_cpu_synchronize_post_init(env); > + smp_wmb(); > } > } > =20 >=20 In theory, there should be no vcpu kick-off after this without some locking operations involved that imply barriers. Did you see real inconsistencies without this explicit one? Jan --------------enigEAE41F9754D45456A580811C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/1OFwACgkQitSsb3rl5xRC8ACgu5PNmTUvfVe2TMk0+bg53O2x MoUAni5E4xvBZDzAqa/gPPBKlW1ij7hL =LwQO -----END PGP SIGNATURE----- --------------enigEAE41F9754D45456A580811C--