From: Eric Blake <eblake@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 4/6] qapi: generate list struct and visit_list for enum
Date: Thu, 05 Jul 2012 07:01:23 -0600 [thread overview]
Message-ID: <4FF59023.7070908@redhat.com> (raw)
In-Reply-To: <1341492525-29809-5-git-send-email-akong@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On 07/05/2012 06:48 AM, Amos Kong wrote:
> Currently, if define an 'enum' and use it in one command's data,
> List struct for enum could not be generated, but it's used in
> qmp function.
>
> For example: KeyCodesList could not be generated.
>>>> qapi-schema.json:
> { 'enum': 'KeyCodes',
> 'data': [ 'shift', 'alt' ... ] }
> { 'command': 'sendkey',
> 'data': { 'keys': ['KeyCodes'], '*hold-time': 'int' } }
>
>>>> qmp-command.h:
> void qmp_sendkey(KeyCodesList * keys, bool has_hold_time, int64_t
> hold_time, Error **errp);
>
> This patch makes qapi can generate List struct for enum.
Grammar nit:
s/makes qapi can/lets/qapi/
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-07-05 13:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 12:48 [Qemu-devel] [PATCH v4 0/6] convert sendkey to qapi Amos Kong
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 1/6] fix doc of using raw values with sendkey Amos Kong
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 2/6] monitor: rename keyname '<' to 'less' Amos Kong
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 3/6] hmp: rename arguments Amos Kong
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 4/6] qapi: generate list struct and visit_list for enum Amos Kong
2012-07-05 13:01 ` Eric Blake [this message]
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey Amos Kong
2012-07-12 15:09 ` Luiz Capitulino
2012-07-18 12:56 ` Amos Kong
2012-07-18 13:50 ` Luiz Capitulino
2012-07-18 18:25 ` Amos Kong
2012-07-25 5:55 ` Amos Kong
2012-07-25 12:38 ` Luiz Capitulino
2012-07-25 13:56 ` Amos Kong
2012-07-05 12:48 ` [Qemu-devel] [PATCH v4 6/6] ps2: output warning when event queue full Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF59023.7070908@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).