From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmmWv-0003zS-8G for qemu-devel@nongnu.org; Thu, 05 Jul 2012 09:55:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmmWo-0007qz-Kd for qemu-devel@nongnu.org; Thu, 05 Jul 2012 09:55:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41484 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmmWo-0007ps-Aa for qemu-devel@nongnu.org; Thu, 05 Jul 2012 09:55:30 -0400 Message-ID: <4FF59CCB.9010608@suse.de> Date: Thu, 05 Jul 2012 15:55:23 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1341494619-4714-1-git-send-email-yeongkyoon.lee@samsung.com> <1341494619-4714-5-git-send-email-yeongkyoon.lee@samsung.com> In-Reply-To: <1341494619-4714-5-git-send-email-yeongkyoon.lee@samsung.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yeongkyoon Lee Cc: Peter Maydell , chenwj@iis.sinica.edu.tw, e.voevodin@samsung.com, qemu-devel@nongnu.org, Blue Swirl , laurent.desnogues@gmail.com Am 05.07.2012 15:23, schrieb Yeongkyoon Lee: > Add an option "--enable-ldst-optimization" to enable CONFIG_QEMU_LDST_O= PTIMIZATION macro for TCG qemu_ld/st optimization. It only works with CON= FIG_SOFTMMU and doesn't work with CONFIG_TCG_PASS_AREG0. >=20 > Signed-off-by: Yeongkyoon Lee > --- > configure | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) >=20 > diff --git a/configure b/configure > index 9f071b7..2b364cc 100755 > --- a/configure > +++ b/configure [...] > @@ -3463,6 +3466,11 @@ echo "EXESUF=3D$EXESUF" >> $config_host_mak > echo "LIBS_QGA+=3D$libs_qga" >> $config_host_mak > echo "POD2MAN=3D$POD2MAN" >> $config_host_mak > =20 > +if [ "$ldst_optimization" =3D "yes" -a "$cpu" !=3D "i386" -a "$cpu" !=3D= "x86_64" ] ; then > + echo "ERROR: qemu_ld/st optimization is only available on i386 or x8= 6_64 hosts" > + exit 1 > +fi [snip] I assume that Samsung is interested in optimizing the Exynos emulation. I think there was already a patchset posted converting target-arm to CONFIG_PASS_TCG_AREG0, only with some slowdowns to be investigated... What is the obstacle for supporting AREG0 mode in your optimization? Regards, Andreas > + > # generate list of library paths for linker script > =20 > $ld --verbose -v 2> /dev/null | grep SEARCH_DIR > ${config_host_ld} > @@ -3696,11 +3704,18 @@ fi > symlink "$source_path/Makefile.target" "$target_dir/Makefile" > =20 > =20 > +target_ldst_optimization=3D"$ldst_optimization" > + > case "$target_arch2" in > alpha | sparc* | xtensa* | ppc*) > echo "CONFIG_TCG_PASS_AREG0=3Dy" >> $config_target_mak > + # qemu_ld/st optimization is not available with CONFIG_TCG_PASS_AR= EG0 > + target_ldst_optimization=3D"no" > ;; > esac > +if [ "$target_ldst_optimization" =3D "yes" -a "$target_softmmu" =3D "y= es" ] ; then > + echo "CONFIG_QEMU_LDST_OPTIMIZATION=3Dy" >> $config_target_mak > +fi > =20 > echo "TARGET_SHORT_ALIGNMENT=3D$target_short_alignment" >> $config_tar= get_mak > echo "TARGET_INT_ALIGNMENT=3D$target_int_alignment" >> $config_target_= mak --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg