From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmmpQ-0007vf-4q for qemu-devel@nongnu.org; Thu, 05 Jul 2012 10:14:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmmpN-00071v-4g for qemu-devel@nongnu.org; Thu, 05 Jul 2012 10:14:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmmpM-00071N-Sc for qemu-devel@nongnu.org; Thu, 05 Jul 2012 10:14:41 -0400 Message-ID: <4FF5A143.2020107@redhat.com> Date: Thu, 05 Jul 2012 08:14:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1341492709-13897-1-git-send-email-owasserm@redhat.com> <1341492709-13897-9-git-send-email-owasserm@redhat.com> In-Reply-To: <1341492709-13897-9-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig38B7915D97C5DF4AB1EA2544" Subject: Re: [Qemu-devel] [PATCH v15 8/9] Add set_cachesize command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , avi@redhat.com, Aidan Shribman , pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig38B7915D97C5DF4AB1EA2544 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/05/2012 06:51 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2). > If XBZRLE cache size is too small there will be many cache miss. >=20 > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- > + { > + .name =3D "migrate_set_cachesize", > + .args_type =3D "value:o", > + .params =3D "value", > + .help =3D "set cache size (in bytes) for XBZRLE migratio= ns," > + "the cache size will be rounded down to the nearest " > + "power of 2.\n" > + "The cache size effects the number of cache misses." > + "In case of a high cache miss ratio you need to increase the c= ache size", Inconsistent indentation. Kill those TABs. > +++ b/migration.c > @@ -22,6 +22,7 @@ > #include "qemu_socket.h" > #include "block-migration.h" > #include "qmp-commands.h" > +#include Urgh. You STILL haven't killed this bogus include, even though I've been mentioning it since my v12 review. I'm really getting frustrated with how long this series is being dragged out. > =20 > //#define DEBUG_MIGRATION > =20 > @@ -43,7 +44,7 @@ enum { > =20 > #define MAX_THROTTLE (32 << 20) /* Migration speed throttling */= > =20 > -/* Migration XBZRLE cache size */ > +/* Migration XBZRLE default cache size */ Again from my v12 review, this hunk should be squashed into the patch that first introduces the comment. > +migrate_set_cachesize > +--------------------- > + > +Set cache size to be used by XBZRLE migration, the cache size will be = round down > +to the nearset power of 2 Another v12 review leftover: s/nearset/nearest/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig38B7915D97C5DF4AB1EA2544 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP9aFDAAoJEKeha0olJ0Nq75MIAJWSg3pZzc2KXJ2F+6PSF8Nt AGYmo5sIuxkOC9xcxvwm1Mf0TnSkfobQ1YqhIU+Ap3IgHof7xHPZ7eDdVsKsqSjj 81axi5oh0s/S3F0j/qEGRqk7dd6wXXE+5E5zl3oFO2fU8yM6HVWFSyfh4uGJVN/I nnliGlriSSejX1GT/I33lbqzzVisZBUpFh2gJHuZgatTmk3lhopeNC/SeUqmnTY3 MvUhCGWeQbQbsSXPDMeV4nJjAFEkxrQUJYnh8AkQ49uQT3uvf07A3zreibaa6F1a 3CNMMfCSNS/ZVp85T10Q8vaNWSVJ5bxbtsc81LAclhaDuVuV7BK433IKs/0r3Sk= =pqhi -----END PGP SIGNATURE----- --------------enig38B7915D97C5DF4AB1EA2544--