From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmmwN-0002x9-EN for qemu-devel@nongnu.org; Thu, 05 Jul 2012 10:22:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmmwH-00019L-1X for qemu-devel@nongnu.org; Thu, 05 Jul 2012 10:21:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmmwG-00018r-PI for qemu-devel@nongnu.org; Thu, 05 Jul 2012 10:21:48 -0400 Message-ID: <4FF5A2A3.8040703@redhat.com> Date: Thu, 05 Jul 2012 08:20:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1341492709-13897-1-git-send-email-owasserm@redhat.com> <1341492709-13897-10-git-send-email-owasserm@redhat.com> In-Reply-To: <1341492709-13897-10-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig08E36C32B021FD74FF1E66C4" Subject: Re: [Qemu-devel] [PATCH v15 9/9] Add XBZRLE statistics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , avi@redhat.com, Aidan Shribman , pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig08E36C32B021FD74FF1E66C4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/05/2012 06:51 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > +++ b/arch_init.c > @@ -202,8 +202,66 @@ int64_t xbzrle_cache_resize(int64_t new_size) > return pow2floor(new_size); > } > =20 > +/* accounting */ > +typedef struct AccountingInfo { The comment didn't add any information. Either drop it, or give a comment that describes what the accounting is for: /* accounting for migration statistics */ > + /* display xbzrle cache size */ > + if (migrate_use_xbzrle()) { > + info->has_cache =3D true; > + info->cache =3D g_malloc0(sizeof(*info->cache)); > + info->cache->cache_size =3D migrate_xbzrle_cache_size(); > + info->cache->xbzrle_bytes =3D xbzrle_mig_bytes_transferre= d(); > + info->cache->xbzrle_pages =3D xbzrle_mig_pages_transferre= d(); Why the two lines with two spaces before '=3D'? > @@ -162,6 +173,8 @@ MigrationInfo *qmp_query_migrate(Error **errp) > info->ram->total =3D ram_bytes_total(); > info->ram->total_time =3D qemu_get_clock_ms(rt_clock) > - s->total_time; > + info->ram->duplicate =3D dup_mig_pages_transferred(); > + info->ram->normal =3D norm_mig_pages_transferred(); And another two spaces before '=3D' > =20 > if (blk_mig_active()) { > info->has_disk =3D true; > @@ -170,6 +183,16 @@ MigrationInfo *qmp_query_migrate(Error **errp) > info->disk->remaining =3D blk_mig_bytes_remaining(); > info->disk->total =3D blk_mig_bytes_total(); > } > + > + if (migrate_use_xbzrle()) { > + info->has_cache =3D true; > + info->cache =3D g_malloc0(sizeof(*info->cache)); > + info->cache->cache_size =3D migrate_xbzrle_cache_size(); > + info->cache->xbzrle_bytes =3D xbzrle_mig_bytes_transferre= d(); > + info->cache->xbzrle_pages =3D xbzrle_mig_pages_transferre= d(); and again > + if (migrate_use_xbzrle()) { > + info->has_cache =3D true; > + info->cache =3D g_malloc0(sizeof(*info->cache)); > + info->cache->cache_size =3D migrate_xbzrle_cache_size(); > + info->cache->xbzrle_bytes =3D xbzrle_mig_bytes_transferre= d(); > + info->cache->xbzrle_pages =3D xbzrle_mig_pages_transferre= d(); and again > @@ -291,13 +315,16 @@ > # @capabilities: #optional a list describing all the migration capabil= ities > # state > # > -# Since: 0.14.0, 'capabilities' since 1.2 > +# @cache: #optional @MigrationStats containing detailed XBZRLE migrati= on > +# statistics > +# > +# Since: 0.14.0, 'capabilities' and 'cache' since 1. s/1.$/1.2/ > +5. Migration is being performed and XBZRLE is active: > + > +-> { "execute": "query-migrate" } > +<- { > + "return":{ > + "status":"active", > + "capabilities" : [ { "capability": "xbzrle", "state" : true }= ], > + "ram":{ > + "total":1057024, > + "remaining":1053304, > + "transferred":3720 s/$/,/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig08E36C32B021FD74FF1E66C4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP9aKjAAoJEKeha0olJ0NqFqcH+wa3Ym+TFHAv210jqZRBlgjg Fr/1X9IW3NmGeQufMajdYERA9vAH9ltrnE23Hi45xZpf+xebX8Wi+fRSJdm2s6F+ lC6WOWj1uhtMvToJEfZSWg5pR7rTaCPso/XZOrYnoE6X9IOrRM/Kzn9FgSNnukWI 38MqO8U0F7KKeANEoUm+Tq+adf+5Mkd/7KydwelNBuVaq6qYwUisNMqhkQYAo5DR 09OxOFtPU9pB+PrbSX4mJDIulJ9tk6g5moLNlr25jBSuP65oiT4X3VqsDN5eK85l zr8LBlSDe75vfjYneof3UJ4UI/7BQHi430TiuyxTQOvnc4cAdX5fqJWGWFql1GQ= =7otF -----END PGP SIGNATURE----- --------------enig08E36C32B021FD74FF1E66C4--