From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmyzI-00052f-NR for qemu-devel@nongnu.org; Thu, 05 Jul 2012 23:13:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmyzG-0006M6-RS for qemu-devel@nongnu.org; Thu, 05 Jul 2012 23:13:44 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:11262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmyzG-0006LV-LY for qemu-devel@nongnu.org; Thu, 05 Jul 2012 23:13:42 -0400 Received: from eusync4.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M6P00MDFYBIS640@mailout2.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 06 Jul 2012 04:14:06 +0100 (BST) Received: from [106.109.8.38] by eusync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M6P00KTHYAOJP40@eusync4.samsung.com> for qemu-devel@nongnu.org; Fri, 06 Jul 2012 04:13:36 +0100 (BST) Date: Fri, 06 Jul 2012 07:13:35 +0400 From: Evgeny Voevodin In-reply-to: <4FF59CCB.9010608@suse.de> Message-id: <4FF657DF.6080901@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-15; format=flowed Content-transfer-encoding: QUOTED-PRINTABLE References: <1341494619-4714-1-git-send-email-yeongkyoon.lee@samsung.com> <1341494619-4714-5-git-send-email-yeongkyoon.lee@samsung.com> <4FF59CCB.9010608@suse.de> Subject: Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Peter Maydell , chenwj@iis.sinica.edu.tw, Yeongkyoon Lee , qemu-devel@nongnu.org, Blue Swirl , laurent.desnogues@gmail.com On 05.07.2012 17:55, Andreas F=E4rber wrote: > Am 05.07.2012 15:23, schrieb Yeongkyoon Lee: >> Add an option "--enable-ldst-optimization" to enable CONFIG_QEMU_L= DST_OPTIMIZATION macro for TCG qemu_ld/st optimization. It only works= with CONFIG_SOFTMMU and doesn't work with CONFIG_TCG_PASS_AREG0. >> >> Signed-off-by: Yeongkyoon Lee >> --- >> configure | 15 +++++++++++++++ >> 1 files changed, 15 insertions(+), 0 deletions(-) >> >> diff --git a/configure b/configure >> index 9f071b7..2b364cc 100755 >> --- a/configure >> +++ b/configure > [...] >> @@ -3463,6 +3466,11 @@ echo "EXESUF=3D$EXESUF" >> $config_host_mak >> echo "LIBS_QGA+=3D$libs_qga" >> $config_host_mak >> echo "POD2MAN=3D$POD2MAN" >> $config_host_mak >> =20 >> +if [ "$ldst_optimization" =3D "yes" -a "$cpu" !=3D "i386" -a "$cp= u" !=3D "x86_64" ] ; then >> + echo "ERROR: qemu_ld/st optimization is only available on i386 = or x86_64 hosts" >> + exit 1 >> +fi > [snip] > > I assume that Samsung is interested in optimizing the Exynos emulat= ion. Nope ) Originally it's from x86 Tizen emulator ) > I think there was already a patchset posted converting target-arm t= o > CONFIG_PASS_TCG_AREG0, only with some slowdowns to be investigated.= .. > What is the obstacle for supporting AREG0 mode in your optimization= ? > > Regards, > Andreas > >> + >> # generate list of library paths for linker script >> =20 >> $ld --verbose -v 2> /dev/null | grep SEARCH_DIR > ${config_host_= ld} >> @@ -3696,11 +3704,18 @@ fi >> symlink "$source_path/Makefile.target" "$target_dir/Makefile" >> =20 >> =20 >> +target_ldst_optimization=3D"$ldst_optimization" >> + >> case "$target_arch2" in >> alpha | sparc* | xtensa* | ppc*) >> echo "CONFIG_TCG_PASS_AREG0=3Dy" >> $config_target_mak >> + # qemu_ld/st optimization is not available with CONFIG_TCG_PA= SS_AREG0 >> + target_ldst_optimization=3D"no" >> ;; >> esac >> +if [ "$target_ldst_optimization" =3D "yes" -a "$target_softmmu" = =3D "yes" ] ; then >> + echo "CONFIG_QEMU_LDST_OPTIMIZATION=3Dy" >> $config_target_ma= k >> +fi >> =20 >> echo "TARGET_SHORT_ALIGNMENT=3D$target_short_alignment" >> $conf= ig_target_mak >> echo "TARGET_INT_ALIGNMENT=3D$target_int_alignment" >> $config_t= arget_mak --=20 Kind regards, Evgeny Voevodin, Technical Leader, Mobile Group, SMRC, Samsung Electronics e-mail: e.voevodin@samsung.com