From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn12C-0005Wy-Iw for qemu-devel@nongnu.org; Fri, 06 Jul 2012 01:24:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn12A-0006VG-QB for qemu-devel@nongnu.org; Fri, 06 Jul 2012 01:24:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn12A-0006V6-Hp for qemu-devel@nongnu.org; Fri, 06 Jul 2012 01:24:50 -0400 Message-ID: <4FF676A7.8050508@redhat.com> Date: Fri, 06 Jul 2012 08:24:55 +0300 From: Orit Wasserman MIME-Version: 1.0 References: <1341492709-13897-1-git-send-email-owasserm@redhat.com> <1341492709-13897-9-git-send-email-owasserm@redhat.com> <4FF5A143.2020107@redhat.com> In-Reply-To: <4FF5A143.2020107@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v15 8/9] Add set_cachesize command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , avi@redhat.com, Aidan Shribman , pbonzini@redhat.com, chegu_vinod@hp.com On 07/05/2012 05:14 PM, Eric Blake wrote: > On 07/05/2012 06:51 AM, Orit Wasserman wrote: >> Change XBZRLE cache size in bytes (the size should be a power of 2). >> If XBZRLE cache size is too small there will be many cache miss. >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> Signed-off-by: Orit Wasserman >> --- > >> + { >> + .name = "migrate_set_cachesize", >> + .args_type = "value:o", >> + .params = "value", >> + .help = "set cache size (in bytes) for XBZRLE migrations," >> + "the cache size will be rounded down to the nearest " >> + "power of 2.\n" >> + "The cache size effects the number of cache misses." >> + "In case of a high cache miss ratio you need to increase the cache size", > > Inconsistent indentation. Kill those TABs. > >> +++ b/migration.c >> @@ -22,6 +22,7 @@ >> #include "qemu_socket.h" >> #include "block-migration.h" >> #include "qmp-commands.h" >> +#include > > Urgh. You STILL haven't killed this bogus include, even though I've > been mentioning it since my v12 review. I'm really getting frustrated > with how long this series is being dragged out. Again I'm really sorry I will be more careful next time Thanks, Orit > >> >> //#define DEBUG_MIGRATION >> >> @@ -43,7 +44,7 @@ enum { >> >> #define MAX_THROTTLE (32 << 20) /* Migration speed throttling */ >> >> -/* Migration XBZRLE cache size */ >> +/* Migration XBZRLE default cache size */ > > Again from my v12 review, this hunk should be squashed into the patch > that first introduces the comment. > >> +migrate_set_cachesize >> +--------------------- >> + >> +Set cache size to be used by XBZRLE migration, the cache size will be round down >> +to the nearset power of 2 > > Another v12 review leftover: > > s/nearset/nearest/ >