From: Michael Tokarev <mjt@tls.msk.ru>
To: Amos Kong <akong@redhat.com>
Cc: qemu-trivial@nongnu.org, aliguori@us.ibm.com, pkrempa@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] vnc: add a more descriptive error message
Date: Fri, 06 Jul 2012 10:45:01 +0400 [thread overview]
Message-ID: <4FF6896D.4070305@msgid.tls.msk.ru> (raw)
In-Reply-To: <4FF65090.3040402@redhat.com>
On 06.07.2012 06:42, Amos Kong wrote:
> On 30/06/12 10:02, akong@redhat.com wrote:
>> From: Amos Kong<akong@redhat.com>
>>
>> Currently qemu outputs some low-level error in qemu-sockets.c
>> when failed to start vnc server.
>> eg. 'getaddrinfo(127.0.0.1,5902): Name or service not known'
>>
>> Some libvirt users could not know what's happened with this
>> unclear error message. This patch added a more descriptive
>> error message.
Gyus, please, pretty PLEASE stop doing things like this.
Amos, your patch does TWO things. One is to clarify error
message as correctly stated in your description, and second
is to change the code to do exit(1) if this message is
generated. So, please, a) add the second fact to the
description, and b) mention why it is needed.
Thanks,
/mjt
next prev parent reply other threads:[~2012-07-06 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1341021237-11293-1-git-send-email-akong@redhat.com>
[not found] ` <1341021740-11426-1-git-send-email-akong@redhat.com>
2012-07-06 2:42 ` [Qemu-devel] [PATCH v2] vnc: add a more descriptive error message Amos Kong
2012-07-06 6:45 ` Michael Tokarev [this message]
2012-07-06 7:31 ` Markus Armbruster
2012-07-06 8:09 ` Amos Kong
2012-07-06 8:14 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF6896D.4070305@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).