From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35571)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Sn2c3-0002ct-Dh
	for qemu-devel@nongnu.org; Fri, 06 Jul 2012 03:06:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Sn2bx-0005dR-9s
	for qemu-devel@nongnu.org; Fri, 06 Jul 2012 03:05:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13134)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Sn2bx-0005dM-1Z
	for qemu-devel@nongnu.org; Fri, 06 Jul 2012 03:05:53 -0400
Message-ID: <4FF68E47.4090204@redhat.com>
Date: Fri, 06 Jul 2012 09:05:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1341222087-24920-1-git-send-email-pbonzini@redhat.com>
	<1341222087-24920-3-git-send-email-pbonzini@redhat.com>
	<CAAu8pHvEUm-0M5m96xuXNWDR4bvLB68f3n8ScVSorXrTrj7omA@mail.gmail.com>
	<4FF3F1E6.1040508@redhat.com>
	<CAAu8pHvqPJG7zMFv8=P+H=Md6SOvpGjrwcgRD1fPD=723jbV2Q@mail.gmail.com>
In-Reply-To: <CAAu8pHvqPJG7zMFv8=P+H=Md6SOvpGjrwcgRD1fPD=723jbV2Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the
 disk's WWN
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

Il 05/07/2012 20:03, Blue Swirl ha scritto:
> > > > +            if (s->wwn) {
> > > > +                outbuf[buflen++] = 0x1; // Binary
> > > > +                outbuf[buflen++] = 0x3; // NAA
> > > > +                outbuf[buflen++] = 0;   // reserved
> > >
> > > C99 comments.
> >
> > Just following the style of this code.  Feel free to send a patch to
> > replace with #defines.
> 
> That's not how we should work. New code should be compliant with our
> goals. Pushing the responsibility for fixing issues to other people
> does not scale.

I believe the coding style are attacking the wrong problem.  It's
end-of-line comments that should be avoided in favor of #defines, packed
structs, designated initializers, etc.  But for end-of-line comments,
C++ comments are superior to /* */ comments.

I do plan to fix the clarity issue with SCSI data structures and
constants.  But for now, the best compromise is to keep C++ comments
IMHO.  I'm not pushing the responsibility to other people in general,
but if they think C++ comments are a major issue they can send patches.

Paolo