Re: [Qemu-devel] [PATCH v2] vnc: add a more descriptive error message

[Michael Tokarev <mjt@tls.msk.ru>]

On 06.07.2012 12:09, Amos Kong wrote:
> ----- Original Message -----
>> Michael Tokarev <mjt@tls.msk.ru> writes:

>>> Gyus, please, pretty PLEASE stop doing things like this.
>>>
>>> Amos, your patch does TWO things.  One is to clarify error
>>> message as correctly stated in your description, and second
>>> is to change the code to do exit(1) if this message is
>>> generated.  So, please, a) add the second fact to the
>>> description, and b) mention why it is needed.
> 
> 
> 'exit(1)' is the original code, my patch just add an error message.

Amos, I'm sorry for that -- it is my ENOCOFFEE case of misreading
the patch.  I read it initially as you've added the "exit" line,
but you actually added the "}" line.  So indeed, this is the right
fix and the description matches what the patch does.

I've seen quite alot of cases when the description was like "clarifying
message" or "moving the code to a separate file", but at the same time
other things has changed, and often changed in a wrong way...

So, yes, it is a very good, and trivial, change, and you may use my

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

The more cases like this is fixed, the better!

Thank you!

/mjt