From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn4bW-00028c-Co for qemu-devel@nongnu.org; Fri, 06 Jul 2012 05:13:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn4bN-0003V1-Eo for qemu-devel@nongnu.org; Fri, 06 Jul 2012 05:13:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn4bA-0003UA-19 for qemu-devel@nongnu.org; Fri, 06 Jul 2012 05:13:25 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q668rWiP011622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 6 Jul 2012 04:53:40 -0400 Message-ID: <4FF6A6C3.4090201@redhat.com> Date: Fri, 06 Jul 2012 10:50:11 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1340984094-5451-1-git-send-email-armbru@redhat.com> <1340984094-5451-33-git-send-email-armbru@redhat.com> <4FF5B247.7070902@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 05.07.2012 18:39, schrieb Markus Armbruster: > Markus Armbruster writes: > >> Kevin Wolf writes: >> >>> Am 29.06.2012 17:34, schrieb Markus Armbruster: >>>> New limits straight from ATA4 6.2 Register delivered data transfer >>>> command sector addressing. >>>> >>>> I figure the old sector limit 63 was blindly copied from the BIOS >>>> int 13 limit. Doesn't apply to the hardware. No idea where the old >>>> cylinder limit comes from. >>>> >>>> Signed-off-by: Markus Armbruster >>> >>> Now I think we have the very same thing in IDE, SCSI and virtio-blk. >>> Would it make sense to have a helper function in hd-geometry.c that >>> takes and validates the geometry from a BlockConf, applies defaults and >>> puts the result into device state fields passed by reference? >> >> I can look into this, but I'm afraid we'd need two helpers, because of >> IDE complications. > > I'd like to try this in a follow-up series, together with a few more > cleanups made possible by this series. Okay? Fine with me. Kevin