From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn8uA-0001N9-KI for qemu-devel@nongnu.org; Fri, 06 Jul 2012 09:49:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn8u5-00057j-Jr for qemu-devel@nongnu.org; Fri, 06 Jul 2012 09:49:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50246 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn8u5-00057c-Dm for qemu-devel@nongnu.org; Fri, 06 Jul 2012 09:49:01 -0400 Message-ID: <4FF6ECC8.9000100@suse.de> Date: Fri, 06 Jul 2012 15:48:56 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1341507652-22155-1-git-send-email-peter.maydell@linaro.org> <1341507652-22155-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1341507652-22155-2-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/6] hw/arm_boot.c: Make ram_size a target_phys_addr_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Peter Crosthwaite , Alexander Graf , qemu-devel@nongnu.org, patches@linaro.org Am 05.07.2012 19:00, schrieb Peter Maydell: > Make the RAM size in arm_boot_info a target_phys_addr_t so > it can express RAM sizes up to the limit imposed by the > physical address size. >=20 > Signed-off-by: Peter Maydell > --- > hw/arm-misc.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/hw/arm-misc.h b/hw/arm-misc.h > index 1f96229..c313027 100644 > --- a/hw/arm-misc.h > +++ b/hw/arm-misc.h > @@ -25,7 +25,7 @@ qemu_irq *armv7m_init(MemoryRegion *address_space_mem= , > =20 > /* arm_boot.c */ > struct arm_boot_info { > - int ram_size; > + target_phys_addr_t ram_size; > const char *kernel_filename; > const char *kernel_cmdline; > const char *initrd_filename; Didn't we conclude in lengthy and emotional discussions that int64_t was the best compromise to solve the highbank and pseries image loading issue= s? What I still dislike about target_phys_addr_t is that "ram_size" is not an address but a size. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg