From: "Andreas Färber" <afaerber@suse.de>
To: Alexander Graf <agraf@suse.de>
Cc: benh@au1.ibm.com, shangw@linux.vnet.ibm.com,
qemu-devel@nongnu.org, Li Zhang <zhlcindy@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, zhlcindy@gmail.com
Subject: Re: [Qemu-devel] [Qemu-ppc][PATCH v5 4/4] spapr: Add support for -vga option
Date: Fri, 06 Jul 2012 15:58:01 +0200 [thread overview]
Message-ID: <4FF6EEE9.8060201@suse.de> (raw)
In-Reply-To: <E8F34981-5F68-4009-8452-78D4F844DF78@suse.de>
Am 06.07.2012 15:50, schrieb Alexander Graf:
>
> On 02.07.2012, at 07:25, zhlcindy@gmail.com wrote:
>
>> @@ -712,6 +730,11 @@ static void ppc_spapr_init(ram_addr_t ram_size,
>> spapr_vscsi_create(spapr->vio_bus);
>> }
>>
>> + /* Graphics */
>> + if (spapr_vga_init(QLIST_FIRST(&spapr->phbs)->host_state.bus)) {
>> + spapr_has_graphics = true;
>> + }
>
> How about
>
> spapr_has_graphics = spapr_vga_init(...);
>
> If that gets you above 80 characters, just shove the parameter to spapr_vga_init into a variable.
Further, that expression could use
PCIHostState *phb = PCI_HOST_BRIDGE(QLIST_FIRST(&spapr->phbs));
spapr_vga_init(phb->bus)
once introduced through the pci_host series. :)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-06 13:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 5:25 [Qemu-devel] [Qemu-ppc][PATCH v5 0/4] Add USB option and enable vga on spapr zhlcindy
2012-07-02 5:25 ` [Qemu-devel] [Qemu-ppc][PATCH v5 1/4] Add usb option in machine options zhlcindy
2012-07-06 13:43 ` Alexander Graf
2012-07-06 15:58 ` Andreas Färber
2012-07-06 16:03 ` Alexander Graf
2012-07-06 16:08 ` Andreas Färber
2012-07-08 14:46 ` Li Zhang
2012-07-08 15:02 ` Alexander Graf
2012-07-08 15:15 ` Li Zhang
2012-07-08 14:21 ` Li Zhang
2012-07-08 14:45 ` Alexander Graf
2012-07-08 14:52 ` Li Zhang
2012-07-02 5:25 ` [Qemu-devel] [Qemu-ppc][PATCH v5 2/4] Add one new file vga-pci.h zhlcindy
2012-07-03 7:17 ` [Qemu-devel] [Qemu-ppc] [PATCH " Li Zhang
2012-07-02 5:25 ` [Qemu-devel] [Qemu-ppc][PATCH v5 3/4] Cleanup pc.h on other platforms zhlcindy
2012-07-02 5:25 ` [Qemu-devel] [Qemu-ppc][PATCH v5 4/4] spapr: Add support for -vga option zhlcindy
2012-07-06 13:50 ` Alexander Graf
2012-07-06 13:58 ` Andreas Färber [this message]
2012-07-08 15:08 ` Li Zhang
2012-07-08 21:54 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF6EEE9.8060201@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=benh@au1.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=shangw@linux.vnet.ibm.com \
--cc=zhlcindy@gmail.com \
--cc=zhlcindy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).