From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55800)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sn92w-0005Ev-0M
	for qemu-devel@nongnu.org; Fri, 06 Jul 2012 09:58:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sn92r-0000KY-FK
	for qemu-devel@nongnu.org; Fri, 06 Jul 2012 09:58:09 -0400
Message-ID: <4FF6EEE9.8060201@suse.de>
Date: Fri, 06 Jul 2012 15:58:01 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1341204647.git.zhlcindy@linux.vnet.ibm.com>
	<0be04c2530ab90a35e26d34cd2fdea49fa392716.1341204647.git.zhlcindy@linux.vnet.ibm.com>
	<E8F34981-5F68-4009-8452-78D4F844DF78@suse.de>
In-Reply-To: <E8F34981-5F68-4009-8452-78D4F844DF78@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-ppc][PATCH v5 4/4] spapr: Add support for
 -vga option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: benh@au1.ibm.com, shangw@linux.vnet.ibm.com, qemu-devel@nongnu.org, Li Zhang <zhlcindy@linux.vnet.ibm.com>, qemu-ppc@nongnu.org, zhlcindy@gmail.com

Am 06.07.2012 15:50, schrieb Alexander Graf:
>=20
> On 02.07.2012, at 07:25, zhlcindy@gmail.com wrote:
>=20
>> @@ -712,6 +730,11 @@ static void ppc_spapr_init(ram_addr_t ram_size,
>>         spapr_vscsi_create(spapr->vio_bus);
>>     }
>>
>> +    /* Graphics */
>> +    if (spapr_vga_init(QLIST_FIRST(&spapr->phbs)->host_state.bus)) {
>> +        spapr_has_graphics =3D true;
>> +    }
>=20
> How about
>=20
> spapr_has_graphics =3D spapr_vga_init(...);
>=20
> If that gets you above 80 characters, just shove the parameter to spapr=
_vga_init into a variable.

Further, that expression could use
PCIHostState *phb =3D PCI_HOST_BRIDGE(QLIST_FIRST(&spapr->phbs));
spapr_vga_init(phb->bus)
once introduced through the pci_host series. :)

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg