From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SnU2N-0000By-A1 for qemu-devel@nongnu.org; Sat, 07 Jul 2012 08:23:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SnU2J-00031r-MH for qemu-devel@nongnu.org; Sat, 07 Jul 2012 08:22:58 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:39985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SnU2J-000306-Dv for qemu-devel@nongnu.org; Sat, 07 Jul 2012 08:22:55 -0400 Received: by weyz53 with SMTP id z53so1642944wey.4 for ; Sat, 07 Jul 2012 05:22:52 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FF82A15.3000904@redhat.com> Date: Sat, 07 Jul 2012 14:22:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1341222087-24920-1-git-send-email-pbonzini@redhat.com> <1341222087-24920-3-git-send-email-pbonzini@redhat.com> <4FF3F1E6.1040508@redhat.com> <4FF68E47.4090204@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org Il 07/07/2012 09:48, Blue Swirl ha scritto: >> > I do plan to fix the clarity issue with SCSI data structures and >> > constants. But for now, the best compromise is to keep C++ comments >> > IMHO. I'm not pushing the responsibility to other people in general, >> > but if they think C++ comments are a major issue they can send patches. > When you add them in new code, that is a problem. New code should > comply with CODING_STYLE, code with other styles should be converted > as it is touched. > > It shouldn't be much effort from your part to change the comments in > this patch to C89 style. Sure, but that would be the wrong fix. The right fix is to augment scsi-defs.h, and avoid the need for comments completely. Paolo