From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Jia Liu" <proljc@gmail.com>,
patches@linaro.org, qemu-devel@nongnu.org,
"Andreas Färber" <afaerber@suse.de>,
"Blue Swirl" <blauwirbel@gmail.com>,
"Avi Kivity" <avi@redhat.com>, "Eric Blake" <eblake@redhat.com>,
"Lluís Vilanova" <vilanova@ac.upc.edu>
Subject: Re: [Qemu-devel] [PATCH v4] bitops.h: Add functions to extract and deposit bitfields
Date: Sun, 08 Jul 2012 12:59:48 +0200 [thread overview]
Message-ID: <4FF96824.8080105@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA-AvT7Z8mv9QpRCAEUT_CWoOotFkL5qHytYw7PGObQeQA@mail.gmail.com>
Am 08.07.2012 12:01, schrieb Peter Maydell:
> On 8 July 2012 10:55, Lluís Vilanova <vilanova@ac.upc.edu> wrote:
>> Wouldn't it be better to use "unsigned int" instead on all the "start" and
>> "length" arguments?
> See the arguments about this on one of the previous patch series:
> http://lists.gnu.org/archive/html/qemu-devel/2012-06/msg04304.html
>
> -- PMM
I just read that arguments and now agree with Blue and with
Lluís that 'unsigned' would be better.
Cheers,
Stefan W.
next prev parent reply other threads:[~2012-07-08 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 14:48 [Qemu-devel] [PATCH v4] bitops.h: Add functions to extract and deposit bitfields Peter Maydell
2012-07-07 9:22 ` Blue Swirl
2012-07-08 9:55 ` Lluís Vilanova
2012-07-08 10:01 ` Peter Maydell
2012-07-08 10:59 ` Stefan Weil [this message]
2012-07-08 11:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF96824.8080105@weilnetz.de \
--to=sw@weilnetz.de \
--cc=afaerber@suse.de \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).