From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1So8tY-0001bn-SK for qemu-devel@nongnu.org; Mon, 09 Jul 2012 04:00:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1So8tO-0000f6-Oe for qemu-devel@nongnu.org; Mon, 09 Jul 2012 04:00:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1So8tO-0000el-Gv for qemu-devel@nongnu.org; Mon, 09 Jul 2012 04:00:26 -0400 Message-ID: <4FFA8F95.3010508@redhat.com> Date: Mon, 09 Jul 2012 10:00:21 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1341586419-32625-1-git-send-email-hdegoede@redhat.com> In-Reply-To: <1341586419-32625-1-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ehci: Kick async schedule on wakeup in the non companion case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/06/12 16:53, Hans de Goede wrote: > Commit 0f588df8b3688b00e77aabaa32e26ece5f19bd39, added code > to ehci_wakeup to kick the async schedule on wakeup, but the else > was positioned wrong making it trigger for devices which are routed > to the companion rather then to the ehci controller itself. > > This patch fixes this. Note that the "programming style" with using the > return at the end of the companion block matches how the companion case > is handled in the other ports ops, and is done this way for consistency. Added to usb patch queue. thanks, Gerd