From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43932)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SoA0D-0002Qe-Pd
	for qemu-devel@nongnu.org; Mon, 09 Jul 2012 05:11:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SoA09-0002Xb-1s
	for qemu-devel@nongnu.org; Mon, 09 Jul 2012 05:11:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44286)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SoA08-0002XN-Q1
	for qemu-devel@nongnu.org; Mon, 09 Jul 2012 05:11:28 -0400
Message-ID: <4FFAA03D.6020302@redhat.com>
Date: Mon, 09 Jul 2012 11:11:25 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1340714974-25489-1-git-send-email-agraf@suse.de>
	<m3zk79wc6i.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3zk79wc6i.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] ahci: add -drive support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel qemu-devel <qemu-devel@nongnu.org>

Am 09.07.2012 10:50, schrieb Markus Armbruster:
> Alexander Graf <agraf@suse.de> writes:
> 
>> We've had support for creating AHCI devices using -device for a while now,
>> but it's cumbersome to users. We really should provide an easier way for
>> them to leverage the power of AHCI!
>>
>> So let's introduce a new if= option to -drive, giving users the same
>> command line experience as for scsi or ide.
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>
>> ---
>>
>> v1 -> v2:
>>
>>   - support more than a single drive per adapter
>>   - support index= option
>>   - treat IF_AHCI the same as IF_IDE
> 
> Inhowfar?  Not obvious to me from the patch, or the diff patch v1.
> 
>>   - add is_ata() helper to match AHCI || IDE
> 
> Not addressed:
> 
> Once we switch to q35, if=ahci will become a redundant wart: to add
> drives to the board's AHCI controller, you'll have to use if=ide.
> if=ahci will create new controllers, which is generally not what you
> want.  Ugh.

Can we even make it the default with q35 as long as our AHCI controller
doesn't also expose a legacy interface for compatibility?

Kevin