From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoBhW-00033j-Sg for qemu-devel@nongnu.org; Mon, 09 Jul 2012 07:00:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoBhO-00052t-Ss for qemu-devel@nongnu.org; Mon, 09 Jul 2012 07:00:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoBhO-00052g-Kl for qemu-devel@nongnu.org; Mon, 09 Jul 2012 07:00:14 -0400 Message-ID: <4FFAB99E.1030203@redhat.com> Date: Mon, 09 Jul 2012 12:59:42 +0200 From: igor MIME-Version: 1.0 References: <1340197164-9574-1-git-send-email-imammedo@redhat.com> <1340197164-9574-4-git-send-email-imammedo@redhat.com> <4FE1D1BB.6030709@suse.de> In-Reply-To: <4FE1D1BB.6030709@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com On 06/20/2012 03:35 PM, Andreas F=E4rber wrote: > Am 20.06.2012 14:59, schrieb Igor Mammedov: >> It's not correct to make CPU runnable (i.e. calling x86_cpu_realize()) >> when not all properties are set (APIC in this case). >> >> Fix it by calling x86_cpu_realize() at board level after APIC is >> initialized, right before cpu_reset(). >> >> Signed-off-by: Igor Mammedov >> --- >> hw/pc.c | 1 + >> target-i386/helper.c | 2 -- >> 2 files changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/hw/pc.c b/hw/pc.c >> index 8368701..8a662cf 100644 >> --- a/hw/pc.c >> +++ b/hw/pc.c >> @@ -948,6 +948,7 @@ static X86CPU *pc_new_cpu(const char *cpu_model) >> env->apic_state =3D apic_init(env, env->cpuid_apic_id); >> } >> qemu_register_reset(pc_cpu_reset, cpu); >> + x86_cpu_realize(OBJECT(cpu), NULL); >> pc_cpu_reset(cpu); >> return cpu; >> } >> diff --git a/target-i386/helper.c b/target-i386/helper.c >> index c52ec13..b38ea7f 100644 >> --- a/target-i386/helper.c >> +++ b/target-i386/helper.c >> @@ -1161,8 +1161,6 @@ X86CPU *cpu_x86_init(const char *cpu_model) >> return NULL; >> } >> >> - x86_cpu_realize(OBJECT(cpu), NULL); >> - >> return cpu; >> } >> > > This will require changes in linux-user and possibly bsd-user. Having a > cpu_realize() would probably help with avoiding #ifdef'ery. > Unfortunately deriving CPUState from DeviceState proves a bit difficult > in the meantime (it worked at one point, now there's lots of circular > header dependencies), and realize support for Object got stopped. > > Andreas > As alternative to keep, I could leave x86_cpu_realize() in=20 cpu_x86_init() and keep pc_cpu_reset() in pc_new_cpu(). That will result=20 in calling cpu_reset() 3 instead of 2 times. Later when apic_init is moved inside cpu.c, a pc_cpu_reset() in=20 pc_new_cpu() would be unnecessary and could be cleaned up then.