From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56657)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SoEcw-0006K1-Sl
	for qemu-devel@nongnu.org; Mon, 09 Jul 2012 10:07:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SoEcn-0005Q0-0G
	for qemu-devel@nongnu.org; Mon, 09 Jul 2012 10:07:50 -0400
Message-ID: <4FFAE5A8.4000308@suse.de>
Date: Mon, 09 Jul 2012 16:07:36 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20120709140429.GA25506@tyr.buserror.net>
In-Reply-To: <20120709140429.GA25506@tyr.buserror.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Scott Wood <scottwood@freescale.com>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org

Am 09.07.2012 16:04, schrieb Scott Wood:
> Recent patches "PPC: e500: rename mpc8544ds into generic file", "PPC:
> e500: split mpc8544ds machine from generic e500 code", and "PPC: e500:
> add generic e500 platform" moved certain e500-related files to the bott=
om
> of the makefile because they're now in ppc/, but the dependency on
> CONFIG_FDT was accidentally dropped.  This broke the build when FDT
> support is not enabled.
>=20
> Signed-off-by: Scott Wood <scottwood@freescale.com>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

But this can probably still be squashed into the original patches for
bisectability I hope?

Andreas

> ---
>  hw/ppc/Makefile.objs |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs
> index 81bcc72..951e407 100644
> --- a/hw/ppc/Makefile.objs
> +++ b/hw/ppc/Makefile.objs
> @@ -27,4 +27,4 @@ obj-y +=3D xilinx_ethlite.o
> =20
>  obj-y :=3D $(addprefix ../,$(obj-y))
> =20
> -obj-y +=3D e500.o mpc8544ds.o e500plat.o
> +obj-$(CONFIG_FDT) +=3D e500.o mpc8544ds.o e500plat.o
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg