From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoL3a-0001te-0n for qemu-devel@nongnu.org; Mon, 09 Jul 2012 16:59:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoL3X-0003ue-Rp for qemu-devel@nongnu.org; Mon, 09 Jul 2012 16:59:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoL3X-0003uV-Ii for qemu-devel@nongnu.org; Mon, 09 Jul 2012 16:59:43 -0400 Message-ID: <4FFB4630.8010209@redhat.com> Date: Mon, 09 Jul 2012 14:59:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1341858170-1903-1-git-send-email-owasserm@redhat.com> <1341858170-1903-9-git-send-email-owasserm@redhat.com> In-Reply-To: <1341858170-1903-9-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig6FC06C7CC0DA4EB48ED85F68" Subject: Re: [Qemu-devel] [PATCH v16 8/9] Add set_cachesize command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , avi@redhat.com, Aidan Shribman , pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6FC06C7CC0DA4EB48ED85F68 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/09/2012 12:22 PM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2). > If XBZRLE cache size is too small there will be many cache miss. >=20 > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > +++ b/qapi-schema.json > @@ -1390,6 +1390,22 @@ > { 'command': 'migrate_set_speed', 'data': {'value': 'int'} } We are copying after bad practice, but... > =20 > ## > +# @migrate_set_cachesize =2E..new QMP commands should prefer '-' over '_'. While the HMP version is fine with migrate_set_cachesize, the QMP command should be migrate-set-cachesize (or even 'migrate-set-cache-size'). > + > +Set cache size to be used by XBZRLE migration, the cache size will be = round down s/round/rounded/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig6FC06C7CC0DA4EB48ED85F68 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP+0YwAAoJEKeha0olJ0NqMlMH/3cWDJt+iVHrgyISKMPZnzFc b7AukU785cDpjEi54rQaiAhioChTDdvEwSHz1VCBWEL+Txems3IfIzMsTVApT6gh d4GIfMngtjd2DL0SSmtPtgTlow3rOj9OT5lpyBeYF4l+uGPkM1uWvTjflkxRI4sm KV9GJ0HjV19xK5/ei67x8ohPoQ0epfee30CHjDh4XymP6VN2ShxziLAxI4RqXnvP 59QbyzvNhIweF/qThlMlrohhiwePvDDygtKQPGvj++x1xstwqUFuyluSc28w11ge V4LjHWFaRibKuiedRSqI+SsUYoz0imuENpNKG8f6EyuaybupNKjfYPf0Gz/JV8I= =cyNW -----END PGP SIGNATURE----- --------------enig6FC06C7CC0DA4EB48ED85F68--