From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45635)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1SoSng-0000w4-2p
	for qemu-devel@nongnu.org; Tue, 10 Jul 2012 01:15:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1SoSne-0005A9-4s
	for qemu-devel@nongnu.org; Tue, 10 Jul 2012 01:15:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44108)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1SoSnd-0005A5-PU
	for qemu-devel@nongnu.org; Tue, 10 Jul 2012 01:15:50 -0400
Message-ID: <4FFBBA7C.6030609@redhat.com>
Date: Tue, 10 Jul 2012 08:15:40 +0300
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <1341858170-1903-1-git-send-email-owasserm@redhat.com>
	<1341858170-1903-9-git-send-email-owasserm@redhat.com>
	<4FFB4630.8010209@redhat.com>
In-Reply-To: <4FFB4630.8010209@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v16 8/9] Add set_cachesize command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard <petters@cs.umu.se>, Benoit Hudzia <benoit.hudzia@sap.com>, avi@redhat.com, Aidan Shribman <aidan.shribman@sap.com>, pbonzini@redhat.com, chegu_vinod@hp.com

On 07/09/2012 11:59 PM, Eric Blake wrote:
> On 07/09/2012 12:22 PM, Orit Wasserman wrote:
>> Change XBZRLE cache size in bytes (the size should be a power of 2).
>> If XBZRLE cache size is too small there will be many cache miss.
>>
>> Signed-off-by: Benoit Hudzia <benoit.hudzia@sap.com>
>> Signed-off-by: Petter Svard <petters@cs.umu.se>
>> Signed-off-by: Aidan Shribman <aidan.shribman@sap.com>
>> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
> 
>> +++ b/qapi-schema.json
>> @@ -1390,6 +1390,22 @@
>>  { 'command': 'migrate_set_speed', 'data': {'value': 'int'} }
> 
> We are copying after bad practice, but...
> 
>>  
>>  ##
>> +# @migrate_set_cachesize
> 
> ...new QMP commands should prefer '-' over '_'.  While the HMP version
> is fine with migrate_set_cachesize, the QMP command should be
> migrate-set-cachesize (or even 'migrate-set-cache-size').
> 
I will change it
Thanks,
Orit
> 
>> +
>> +Set cache size to be used by XBZRLE migration, the cache size will be round down
> 
> s/round/rounded/
>