From: Paolo Bonzini <pbonzini@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Alexander Graf <agraf@suse.de>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02
Date: Tue, 10 Jul 2012 09:06:54 +0200 [thread overview]
Message-ID: <4FFBD48E.3030807@redhat.com> (raw)
In-Reply-To: <4FFBC460.2070104@suse.de>
Il 10/07/2012 07:57, Hannes Reinecke ha scritto:
>> > This will make migration impossible not to mention the fact that
>> > casting a pointer to a uint64_t is really broken.
>> >
> Hey, this is _NOT_ an address. It's a simple way of generating a
> system-wide unique SAS address.
>
> The whole thing is informational anyway, and can only be seen when
> using the (proprietary) MegaCLI userspace command.
So even on real hardware it is not exported to the VPD (in the case of
the per-LUN address)? And the per-port address is also not visible in VPD?
I recently added a wwn property to scsi-{hd,cd}, a similar property
should perhaps be added to the megasas device. We can do the same thing
and add a default. Not the pointer value, though, because it is not
migratable. A counter is also problematic for migration when you have
hotplug/hotunplug. You can instead use something like a CRC32 of the
device id.
Once it's added, we can add support for it in SCSIBusInfo so that it is
exported via VPD.
> Okay, so here's the challenge: We need to generate a system-wide
> unique SAS address, one per SCSI device and one per megasas instance.
> A simple counter won't work, as we might have several qemu instances
> running. Which would result in all of them having the same SAS
> address for the host.
That's not a problem as long as we're not supporting things like
persistent reservations across guests (just like it's not a problem if
you give the same MAC address to network cards with slirp).
Paolo
next prev parent reply other threads:[~2012-07-10 7:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 9:41 [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02 Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 01/14] scsi: simplify handling of the VPD page length field Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN Paolo Bonzini
2012-07-03 19:09 ` Blue Swirl
2012-07-04 7:33 ` Paolo Bonzini
2012-07-05 18:03 ` Blue Swirl
2012-07-06 7:05 ` Paolo Bonzini
2012-07-07 7:48 ` Blue Swirl
2012-07-07 12:22 ` Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 03/14] atapi: implement READ DISC INFORMATION Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 04/14] scsi-disk: " Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 05/14] ISCSI: Add SCSI passthrough via scsi-generic to libiscsi Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 06/14] ISCSI: force use of sg for SMC and SSC devices Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 07/14] megasas: Add header file Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 08/14] megasas: LSI Megaraid SAS HBA emulation Paolo Bonzini
2012-07-03 19:09 ` Blue Swirl
2012-07-04 5:52 ` Hannes Reinecke
2012-07-04 7:33 ` Paolo Bonzini
2012-07-05 6:46 ` Hannes Reinecke
2012-07-02 9:41 ` [Qemu-devel] [PATCH 09/14] virtio-scsi: do not crash on adding buffers to the event queue Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 10/14] scsi: Fix data length == SCSI_SENSE_BUF_SIZE Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 11/14] scsi: Fix LOAD_UNLOAD Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 12/14] scsi: Ensure command and transfer lengths are set for all SCSI devices Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 13/14] scsi: Add basic support for SCSI media changer commands Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 14/14] scsi: Fix transfer length for READ POSITION commands Paolo Bonzini
2012-07-09 16:48 ` [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02 Anthony Liguori
2012-07-09 23:09 ` Alexander Graf
2012-07-09 23:19 ` Anthony Liguori
2012-07-10 5:57 ` Hannes Reinecke
2012-07-10 7:06 ` Paolo Bonzini [this message]
2012-07-10 12:52 ` Anthony Liguori
2012-07-10 13:01 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFBD48E.3030807@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=hare@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).