From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoWlb-0003TN-QS for qemu-devel@nongnu.org; Tue, 10 Jul 2012 05:30:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoWlX-0007Gt-4l for qemu-devel@nongnu.org; Tue, 10 Jul 2012 05:29:59 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:39747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoWlW-0007Gh-SI for qemu-devel@nongnu.org; Tue, 10 Jul 2012 05:29:55 -0400 Received: by pbbro12 with SMTP id ro12so7505pbb.4 for ; Tue, 10 Jul 2012 02:29:52 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FFBF60A.6030705@redhat.com> Date: Tue, 10 Jul 2012 11:29:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1341861429-6297-1-git-send-email-minyard@acm.org> <1341861429-6297-5-git-send-email-minyard@acm.org> In-Reply-To: <1341861429-6297-5-git-send-email-minyard@acm.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/9] Add a base IPMI interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org Cc: Corey Minyard , qemu-devel@nongnu.org Il 09/07/2012 21:17, minyard@acm.org ha scritto: > + > +/* Phyical interface types. */ > +#define IPMI_KCS 1 > +#define IPMI_BT 2 > +#define IPMI_SMIC 3 The code is not 100% consistent for values that are defined in hardware specs (enums are preferred for new code, but that's not really enforced). However, for everything else please use enums rather than arbitrary #defines. Paolo