* Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access [not found] ` <4FEDD9E7.9040702@siemens.com> @ 2012-07-02 9:07 ` Avi Kivity 2012-07-02 9:07 ` Avi Kivity 2012-07-10 10:41 ` Jan Kiszka 0 siblings, 2 replies; 5+ messages in thread From: Avi Kivity @ 2012-07-02 9:07 UTC (permalink / raw) To: Jan Kiszka Cc: Anthony Liguori, Liu Ping Fan, qemu-devel, kvm, Marcelo Tosatti On 06/29/2012 07:37 PM, Jan Kiszka wrote: > Instead of flushing pending coalesced MMIO requests on every vmexit, > this provides a mechanism to selectively flush when memory regions > related to the coalesced one are accessed. This first of all includes > the coalesced region itself but can also applied to other regions, e.g. > of the same device, by calling memory_region_set_flush_coalesced. Looks fine. I have a hard time deciding whether this should go through the kvm tree or memory tree. Anthony, perhaps you can commit it directly to avoid the livelock? Reviewed-by: Avi Kivity <avi@redhat.com> -- error compiling committee.c: too many arguments to function ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access 2012-07-02 9:07 ` [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access Avi Kivity @ 2012-07-02 9:07 ` Avi Kivity 2012-07-10 10:41 ` Jan Kiszka 1 sibling, 0 replies; 5+ messages in thread From: Avi Kivity @ 2012-07-02 9:07 UTC (permalink / raw) To: Jan Kiszka Cc: Anthony Liguori, Liu Ping Fan, qemu-devel, kvm, Marcelo Tosatti On 07/02/2012 12:07 PM, Avi Kivity wrote: > > Reviewed-by: Avi Kivity <avi@redhat.com> (for the entire patchset) -- error compiling committee.c: too many arguments to function ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access 2012-07-02 9:07 ` [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access Avi Kivity 2012-07-02 9:07 ` Avi Kivity @ 2012-07-10 10:41 ` Jan Kiszka 2012-08-17 10:55 ` Jan Kiszka 1 sibling, 1 reply; 5+ messages in thread From: Jan Kiszka @ 2012-07-10 10:41 UTC (permalink / raw) To: Anthony Liguori Cc: Marcelo Tosatti, Liu Ping Fan, Avi Kivity, kvm, qemu-devel On 2012-07-02 11:07, Avi Kivity wrote: > On 06/29/2012 07:37 PM, Jan Kiszka wrote: >> Instead of flushing pending coalesced MMIO requests on every vmexit, >> this provides a mechanism to selectively flush when memory regions >> related to the coalesced one are accessed. This first of all includes >> the coalesced region itself but can also applied to other regions, e.g. >> of the same device, by calling memory_region_set_flush_coalesced. > > Looks fine. > > I have a hard time deciding whether this should go through the kvm tree > or memory tree. Anthony, perhaps you can commit it directly to avoid > the livelock? > > Reviewed-by: Avi Kivity <avi@redhat.com> > Anthony, ping? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access 2012-07-10 10:41 ` Jan Kiszka @ 2012-08-17 10:55 ` Jan Kiszka 2012-08-19 9:46 ` Avi Kivity 0 siblings, 1 reply; 5+ messages in thread From: Jan Kiszka @ 2012-08-17 10:55 UTC (permalink / raw) To: Anthony Liguori Cc: Marcelo Tosatti, Liu Ping Fan, Avi Kivity, kvm, qemu-devel On 2012-07-10 12:41, Jan Kiszka wrote: > On 2012-07-02 11:07, Avi Kivity wrote: >> On 06/29/2012 07:37 PM, Jan Kiszka wrote: >>> Instead of flushing pending coalesced MMIO requests on every vmexit, >>> this provides a mechanism to selectively flush when memory regions >>> related to the coalesced one are accessed. This first of all includes >>> the coalesced region itself but can also applied to other regions, e.g. >>> of the same device, by calling memory_region_set_flush_coalesced. >> >> Looks fine. >> >> I have a hard time deciding whether this should go through the kvm tree >> or memory tree. Anthony, perhaps you can commit it directly to avoid >> the livelock? >> >> Reviewed-by: Avi Kivity <avi@redhat.com> >> > > Anthony, ping? Argh, missed that this series was forgotten. Patch 1 is a bug fix, will resend it separately so that it can make it into 1.2. Will repost the rest once master reopens. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access 2012-08-17 10:55 ` Jan Kiszka @ 2012-08-19 9:46 ` Avi Kivity 0 siblings, 0 replies; 5+ messages in thread From: Avi Kivity @ 2012-08-19 9:46 UTC (permalink / raw) To: Jan Kiszka Cc: Anthony Liguori, Liu Ping Fan, qemu-devel, kvm, Marcelo Tosatti On 08/17/2012 01:55 PM, Jan Kiszka wrote: > On 2012-07-10 12:41, Jan Kiszka wrote: >> On 2012-07-02 11:07, Avi Kivity wrote: >>> On 06/29/2012 07:37 PM, Jan Kiszka wrote: >>>> Instead of flushing pending coalesced MMIO requests on every vmexit, >>>> this provides a mechanism to selectively flush when memory regions >>>> related to the coalesced one are accessed. This first of all includes >>>> the coalesced region itself but can also applied to other regions, e.g. >>>> of the same device, by calling memory_region_set_flush_coalesced. >>> >>> Looks fine. >>> >>> I have a hard time deciding whether this should go through the kvm tree >>> or memory tree. Anthony, perhaps you can commit it directly to avoid >>> the livelock? >>> >>> Reviewed-by: Avi Kivity <avi@redhat.com> >>> >> >> Anthony, ping? > > Argh, missed that this series was forgotten. Patch 1 is a bug fix, will > resend it separately so that it can make it into 1.2. Will repost the > rest once master reopens. My fault, I should have just taken it into memory/core and sent a pull request. Sorry about that. -- error compiling committee.c: too many arguments to function ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-19 9:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1340814444.git.jan.kiszka@siemens.com>
[not found] ` <35d20ce2ae928e21ff715c86f854860d164ff8c9.1340814444.git.jan.kiszka@siemens.com>
[not found] ` <4FEC814C.9040808@redhat.com>
[not found] ` <4FEDD9E7.9040702@siemens.com>
2012-07-02 9:07 ` [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access Avi Kivity
2012-07-02 9:07 ` Avi Kivity
2012-07-10 10:41 ` Jan Kiszka
2012-08-17 10:55 ` Jan Kiszka
2012-08-19 9:46 ` Avi Kivity
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).