From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38727)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1Sogbe-0006TB-Op
	for qemu-devel@nongnu.org; Tue, 10 Jul 2012 16:00:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1Sogbc-0004bE-F1
	for qemu-devel@nongnu.org; Tue, 10 Jul 2012 16:00:22 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:54573)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1Sogbc-0004b5-7L
	for qemu-devel@nongnu.org; Tue, 10 Jul 2012 16:00:20 -0400
Received: by obbta14 with SMTP id ta14so408044obb.4
	for <qemu-devel@nongnu.org>; Tue, 10 Jul 2012 13:00:18 -0700 (PDT)
Message-ID: <4FFC89D0.8020600@acm.org>
Date: Tue, 10 Jul 2012 15:00:16 -0500
From: Corey Minyard <tcminyard@gmail.com>
MIME-Version: 1.0
References: <1341861429-6297-1-git-send-email-minyard@acm.org>
	<1341861429-6297-6-git-send-email-minyard@acm.org>
	<4FFBF6F3.2090808@redhat.com>
In-Reply-To: <4FFBF6F3.2090808@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/9] IPMI: Add a PC ISA type structure
Reply-To: minyard@acm.org
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On 07/10/2012 04:33 AM, Paolo Bonzini wrote:
> Here, you should add a "normal" chardev property so that people can use
> -chardev and -device to create the IPMI interface.  The device can be
> created like this:
>
>     -chardev ...,id=charipmi -device ipmi,interface=kcs,chardev=charipmi
>
> If the chardev is absent, the local interface is used instead.
>
> See docs/qdev-device-use.txt for more information.
>
I had originally used a "normal" chardev here.  However, I needed a way 
for the connection to be re-established if it dropped for some reason, 
for obvious reasons.  The standard chardev doesn't seem to have any 
provision for this, at least none that I could find.

Am I missing something?  If not, should I add that capability to the 
chardev?

-corey