From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58389)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dlaor@redhat.com>) id 1SotIA-0007KZ-8z
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 05:33:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dlaor@redhat.com>) id 1SotI5-0002e1-G7
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 05:33:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49679)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dlaor@redhat.com>) id 1SotI5-0002dp-8H
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 05:33:01 -0400
Message-ID: <4FFD4842.6010704@redhat.com>
Date: Wed, 11 Jul 2012 12:32:50 +0300
From: Dor Laor <dlaor@redhat.com>
MIME-Version: 1.0
References: <1340664362-25603-1-git-send-email-aliguori@us.ibm.com>
	<1340664362-25603-5-git-send-email-aliguori@us.ibm.com>
	<4FE8ED50.3090803@us.ibm.com>
	<20120626104851.GF11372@amit.redhat.com>
	<4FE9B2A0.2030002@us.ibm.com>
	<20120706120603.GA6446@amit.redhat.com>
In-Reply-To: <20120706120603.GA6446@amit.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] virtio-rng: hardware random number
 generator device
Reply-To: dlaor@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Juan Quintela <quintela@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Andreas Faerber <afaerber@suse.de>

On 07/06/2012 03:06 PM, Amit Shah wrote:
> On (Tue) 26 Jun 2012 [08:01:20], Anthony Liguori wrote:
>> >On 06/26/2012 05:48 AM, Amit Shah wrote:
>>> > >On (Mon) 25 Jun 2012 [17:59:28], Anthony Liguori wrote:
>>>> > >>On 06/25/2012 05:46 PM, Anthony Liguori wrote:
>>>>> > >>>From: Amit Shah<amit.shah@redhat.com>
>>> > >
>>>>> > >>>diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
>>> > >
>>>>> > >>>+static void virtio_rng_class_init(ObjectClass *klass, void *data)
>>>>> > >>>+{
>>>>> > >>>+    DeviceClass *dc = DEVICE_CLASS(klass);
>>>>> > >>>+    PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
>>>>> > >>>+
>>>>> > >>>+    k->init = virtio_rng_init_pci;
>>>>> > >>>+    k->exit = virtio_rng_exit_pci;
>>>>> > >>>+    k->vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET;
>>>>> > >>>+    k->device_id = PCI_DEVICE_ID_VIRTIO_RNG;
>>>>> > >>>+    k->revision = VIRTIO_PCI_ABI_VERSION;
>>>>> > >>>+    k->class_id = PCI_CLASS_OTHERS;
>>>> > >>
>>>> > >>WHQL tends to get very particular about PCI classes.  Do we
>>>> > >>understand the implications of making this CLASS_OTHERS and WHQL?
>>> > >
>>> > >I've not asked around; will update with info when I get it.
>> >
>> >Thanks.
> ... and I heard back: PCI_CLASS_OTHERS is fine; no problem.
>

Unclassified device (PCI_CLASS_OTHERS) is the easiest way to pass M$ 
WHQL. It doesn't do any functional tests to the device itself, unlike 
NICs/StorPort devices. If M$ had a specific entropy device type it would 
be good to use it but I doubt such exist.