From: Kevin Wolf <kwolf@redhat.com>
To: blauwirbel@gmail.com
Cc: blueswirl@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types
Date: Wed, 11 Jul 2012 14:49:39 +0200 [thread overview]
Message-ID: <4FFD7663.8030102@redhat.com> (raw)
In-Reply-To: <cb6fdbe6a2451359e56292d32818414db473bfdd.1341775234.git.blauwirbel@gmail.com>
Am 08.07.2012 21:22, schrieb blauwirbel@gmail.com:
> From: Blue Swirl <blauwirbel@gmail.com>
>
> Use 'unsigned int' for bit numbers instead of 'unsigned long' or
> 'int'. Adjust asserts.
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
I haven't followed the original discussion and therefore don't know what
the controversy is about (nor do I feel like reading it up), but if
there is no consensus, I would expect even more than already for normal
patches that the commit message doesn't only state the obvious change,
but also the reasons for the change.
This message isn't much different from the famous "i++; /* increase i by
one */" code comment.
Kevin
next prev parent reply other threads:[~2012-07-11 12:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 19:22 [Qemu-devel] [PATCH v2 0/3] bitops patches blauwirbel
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 1/3] bitops: fix types blauwirbel
2012-07-09 7:49 ` Markus Armbruster
2012-07-10 19:18 ` Blue Swirl
2012-07-10 19:37 ` Peter Maydell
2012-07-10 20:01 ` Blue Swirl
2012-07-10 21:36 ` Peter Maydell
2012-07-12 20:18 ` Blue Swirl
2012-07-12 21:05 ` Peter Maydell
2012-07-11 12:49 ` Kevin Wolf [this message]
2012-07-12 20:21 ` Blue Swirl
2012-07-13 8:59 ` Kevin Wolf
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 2/3] bitops: drop volatile qualifier blauwirbel
2012-07-09 7:46 ` Peter Maydell
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 3/3] bitops: use bool blauwirbel
2012-07-09 7:43 ` Markus Armbruster
2012-07-10 19:32 ` Blue Swirl
2012-07-09 8:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD7663.8030102@redhat.com \
--to=kwolf@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=blueswirl@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).