From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>,
Anthony Liguori <aliguori@us.ibm.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage)
Date: Wed, 11 Jul 2012 15:15:05 +0200 [thread overview]
Message-ID: <4FFD7C59.4050402@redhat.com> (raw)
In-Reply-To: <4FFD7404.7060709@redhat.com>
Il 11/07/2012 14:39, Kevin Wolf ha scritto:
> Am 11.07.2012 07:25, schrieb Michael Tokarev:
>> On 11.07.2012 09:09, Stefan Weil wrote:
>>> Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW)
>>> because it partially replaced "ret" by "count".
>>>
>>> It also changed the handling of EINTR in a wrong way.
>>>
>>> The patch restores the old code for these two changes.
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>
>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>>
>> Granted, I never _ever_ tested or even compiled this
>> part. Should have been. Thank you Stefan!
>
> Then I guess you should not have sent a pull request. :-)
Not that Anthony would have tested mingw...
Paolo
next prev parent reply other threads:[~2012-07-11 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 5:09 [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage) Stefan Weil
2012-07-11 5:25 ` Michael Tokarev
2012-07-11 12:39 ` Kevin Wolf
2012-07-11 13:15 ` Paolo Bonzini [this message]
2012-07-11 13:50 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD7C59.4050402@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).