From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SowlF-0003gl-2y for qemu-devel@nongnu.org; Wed, 11 Jul 2012 09:15:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sowl8-0004Ft-CL for qemu-devel@nongnu.org; Wed, 11 Jul 2012 09:15:20 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:59519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sowl8-0004FN-5j for qemu-devel@nongnu.org; Wed, 11 Jul 2012 09:15:14 -0400 Received: by yenl1 with SMTP id l1so1262046yen.4 for ; Wed, 11 Jul 2012 06:15:12 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FFD7C59.4050402@redhat.com> Date: Wed, 11 Jul 2012 15:15:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1341983345-25255-1-git-send-email-sw@weilnetz.de> <4FFD0E48.4090800@msgid.tls.msk.ru> <4FFD7404.7060709@redhat.com> In-Reply-To: <4FFD7404.7060709@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Stefan Weil , Anthony Liguori , Michael Tokarev , qemu-devel@nongnu.org Il 11/07/2012 14:39, Kevin Wolf ha scritto: > Am 11.07.2012 07:25, schrieb Michael Tokarev: >> On 11.07.2012 09:09, Stefan Weil wrote: >>> Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW) >>> because it partially replaced "ret" by "count". >>> >>> It also changed the handling of EINTR in a wrong way. >>> >>> The patch restores the old code for these two changes. >>> >>> Signed-off-by: Stefan Weil >> >> Signed-off-by: Michael Tokarev >> >> Granted, I never _ever_ tested or even compiled this >> part. Should have been. Thank you Stefan! > > Then I guess you should not have sent a pull request. :-) Not that Anthony would have tested mingw... Paolo