From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoxLz-0003hG-Ow for qemu-devel@nongnu.org; Wed, 11 Jul 2012 09:53:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoxLs-00024M-UC for qemu-devel@nongnu.org; Wed, 11 Jul 2012 09:53:19 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:57678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoxLs-00022d-NS for qemu-devel@nongnu.org; Wed, 11 Jul 2012 09:53:12 -0400 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 11 Jul 2012 07:53:03 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 4937F1FF0072 for ; Wed, 11 Jul 2012 13:51:57 +0000 (WET) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6BDp4pH141864 for ; Wed, 11 Jul 2012 07:51:15 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6BDol2E011666 for ; Wed, 11 Jul 2012 07:50:47 -0600 Message-ID: <4FFD84B3.7060509@us.ibm.com> Date: Wed, 11 Jul 2012 08:50:43 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1341983345-25255-1-git-send-email-sw@weilnetz.de> <4FFD0E48.4090800@msgid.tls.msk.ru> <4FFD7404.7060709@redhat.com> <4FFD7C59.4050402@redhat.com> In-Reply-To: <4FFD7C59.4050402@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Stefan Weil , Michael Tokarev , qemu-devel@nongnu.org On 07/11/2012 08:15 AM, Paolo Bonzini wrote: > Il 11/07/2012 14:39, Kevin Wolf ha scritto: >> Am 11.07.2012 07:25, schrieb Michael Tokarev: >>> On 11.07.2012 09:09, Stefan Weil wrote: >>>> Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW) >>>> because it partially replaced "ret" by "count". >>>> >>>> It also changed the handling of EINTR in a wrong way. >>>> >>>> The patch restores the old code for these two changes. >>>> >>>> Signed-off-by: Stefan Weil >>> >>> Signed-off-by: Michael Tokarev >>> >>> Granted, I never _ever_ tested or even compiled this >>> part. Should have been. Thank you Stefan! >> >> Then I guess you should not have sent a pull request. :-) > > Not that Anthony would have tested mingw... Nope. It's not efficient to rely on the maintainer to do your testing for you. If you modify code in a non-trivial way, you should attempt to test it. Anyway, I'll apply this patch ASAP. Regards, Anthony Liguori > > Paolo > >