From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoxoZ-0003pA-CF for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:23:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoxoU-0002av-Iy for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:22:50 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:57324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoxoU-0002ab-BZ for qemu-devel@nongnu.org; Wed, 11 Jul 2012 10:22:46 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 11 Jul 2012 08:22:41 -0600 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id E1547C900FD for ; Wed, 11 Jul 2012 10:22:23 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6BEMN6h195452 for ; Wed, 11 Jul 2012 10:22:23 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6BEMMRK006764 for ; Wed, 11 Jul 2012 10:22:23 -0400 Message-ID: <4FFD8C12.6090609@linux.vnet.ibm.com> Date: Wed, 11 Jul 2012 10:22:10 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1341917019-23224-1-git-send-email-chouteau@adacore.com> <4FFC079A.9090603@redhat.com> <4FFC0BB6.6080500@adacore.com> <4FFC0CA6.5060408@redhat.com> <4FFC3013.9040807@adacore.com> In-Reply-To: <4FFC3013.9040807@adacore.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: Anthony Liguori , Stefan Hajnoczi , Stefan Weil , Michael Roth , qemu-devel@nongnu.org, Blue Swirl , Paolo Bonzini , Luiz Capitulino , =?ISO-8859-15?Q?Andreas_F=E4?= =?ISO-8859-15?Q?rber?= On 07/10/2012 09:37 AM, Fabien Chouteau wrote: > On 07/10/2012 01:06 PM, Paolo Bonzini wrote: >> Il 10/07/2012 13:02, Fabien Chouteau ha scritto: >>>>>>> Bridge helper uses ioctl's not available on old Linux versions, we add >>>>>>> this flag to disable the build. >>>>> >>>>> Which ioctls? Please detect them, so that we can also work around them >>>>> perhaps. >>>>> >>> There SIOCBRADDIF at least, maybe it's the only one. >> >> So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were >> inclined to do so... >> > > Unfortunately I don't have time to go deep into the code. It's not a > feature I plan to use, so the quickest solution for me is to disable it. > > Corey, I can see that you developed the bridge helper, can you please > take a look at this issue? > Apologies, I was out yesterday. I see your new patch series is progressing. I'll take over if/when you want. -- Regards, Corey