From: Corey Bryant <coreyb@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Fabien Chouteau <chouteau@adacore.com>
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
"Stefan Hajnoczi" <stefanha@linux.vnet.ibm.com>,
"Stefan Weil" <sw@weilnetz.de>,
qemu-devel@nongnu.org, "Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Blue Swirl" <blauwirbel@gmail.com>,
"Luiz Capitulino" <lcapitulino@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag
Date: Wed, 11 Jul 2012 11:27:26 -0400 [thread overview]
Message-ID: <4FFD9B5E.2000501@linux.vnet.ibm.com> (raw)
In-Reply-To: <4FFD944E.8050004@redhat.com>
On 07/11/2012 10:57 AM, Paolo Bonzini wrote:
> Il 11/07/2012 16:56, Fabien Chouteau ha scritto:
>>>>>>>> So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were
>>>>>>>> inclined to do so...
>>>>>>>>
>>>>>>
>>>>>> Unfortunately I don't have time to go deep into the code. It's not a
>>>>>> feature I plan to use, so the quickest solution for me is to disable it.
>>>>>>
>>>>>> Corey, I can see that you developed the bridge helper, can you please
>>>>>> take a look at this issue?
>>>>>>
>>>>
>>>> Apologies, I was out yesterday. I see your new patch series is progressing. I'll take over if/when you want.
>>>>
>> Beside the --enable/--disable patch, there's another question for you.
>> Is it possible to implement qemu-bridge-adapter without SIOCBRADDIF?
>
> Yes, with the (obsolete) SIOCDEVPRIVATE ioctl. It has multiple
> subcommands, one of which is BRCTL_ADD_IF.
>
> Paolo
>
I'll test this out and provide a patch that uses BRCTL_ADD_IF if
SIOCBRADDIF is undefined.
--
Regards,
Corey
next prev parent reply other threads:[~2012-07-11 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 10:43 [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag Fabien Chouteau
2012-07-10 10:44 ` Paolo Bonzini
2012-07-10 11:02 ` Fabien Chouteau
2012-07-10 11:06 ` Paolo Bonzini
2012-07-10 13:37 ` Fabien Chouteau
2012-07-11 14:22 ` Corey Bryant
2012-07-11 14:56 ` Fabien Chouteau
2012-07-11 14:57 ` Paolo Bonzini
2012-07-11 15:27 ` Corey Bryant [this message]
2012-07-10 17:29 ` Andreas Färber
2012-07-11 8:56 ` Fabien Chouteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD9B5E.2000501@linux.vnet.ibm.com \
--to=coreyb@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=chouteau@adacore.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).