From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Soyx4-0003Vn-TJ for qemu-devel@nongnu.org; Wed, 11 Jul 2012 11:35:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Soywz-0003Wa-82 for qemu-devel@nongnu.org; Wed, 11 Jul 2012 11:35:42 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:52689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Soywz-0003Tv-3k for qemu-devel@nongnu.org; Wed, 11 Jul 2012 11:35:37 -0400 Received: from /spool/local by e3.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 11 Jul 2012 11:35:30 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 30CDF6E8184 for ; Wed, 11 Jul 2012 11:27:33 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6BFRW6q161788 for ; Wed, 11 Jul 2012 11:27:32 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6BKwLtM001917 for ; Wed, 11 Jul 2012 16:58:22 -0400 Message-ID: <4FFD9B5E.2000501@linux.vnet.ibm.com> Date: Wed, 11 Jul 2012 11:27:26 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1341917019-23224-1-git-send-email-chouteau@adacore.com> <4FFC079A.9090603@redhat.com> <4FFC0BB6.6080500@adacore.com> <4FFC0CA6.5060408@redhat.com> <4FFC3013.9040807@adacore.com> <4FFD8C12.6090609@linux.vnet.ibm.com> <4FFD940D.30500@adacore.com> <4FFD944E.8050004@redhat.com> In-Reply-To: <4FFD944E.8050004@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Fabien Chouteau Cc: Anthony Liguori , Stefan Hajnoczi , Stefan Weil , qemu-devel@nongnu.org, Michael Roth , Blue Swirl , Luiz Capitulino , =?ISO-8859-15?Q?Andreas_F=E4rber?= On 07/11/2012 10:57 AM, Paolo Bonzini wrote: > Il 11/07/2012 16:56, Fabien Chouteau ha scritto: >>>>>>>> So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were >>>>>>>> inclined to do so... >>>>>>>> >>>>>> >>>>>> Unfortunately I don't have time to go deep into the code. It's not a >>>>>> feature I plan to use, so the quickest solution for me is to disable it. >>>>>> >>>>>> Corey, I can see that you developed the bridge helper, can you please >>>>>> take a look at this issue? >>>>>> >>>> >>>> Apologies, I was out yesterday. I see your new patch series is progressing. I'll take over if/when you want. >>>> >> Beside the --enable/--disable patch, there's another question for you. >> Is it possible to implement qemu-bridge-adapter without SIOCBRADDIF? > > Yes, with the (obsolete) SIOCDEVPRIVATE ioctl. It has multiple > subcommands, one of which is BRCTL_ADD_IF. > > Paolo > I'll test this out and provide a patch that uses BRCTL_ADD_IF if SIOCBRADDIF is undefined. -- Regards, Corey