From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60760)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SozOY-0003Y9-Qt
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:04:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SozOQ-0004b2-FS
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:04:06 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:35910)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SozOQ-0004aH-6f
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:03:58 -0400
Received: by pbbro12 with SMTP id ro12so2328803pbb.4
	for <qemu-devel@nongnu.org>; Wed, 11 Jul 2012 09:03:56 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FFDA3E5.8020701@redhat.com>
Date: Wed, 11 Jul 2012 18:03:49 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com>
	<1339772759-31004-13-git-send-email-pbonzini@redhat.com>
	<4FDB74B3.4080801@redhat.com>
In-Reply-To: <4FDB74B3.4080801@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 12/36] block: sort BlockDeviceIoStatus
	errors by severity
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com, lcapitulino@redhat.com

Il 15/06/2012 19:45, Eric Blake ha scritto:
>> > +++ b/qapi-schema.json
>> > @@ -429,7 +429,7 @@
>> >  #
>> >  # Since: 1.0
>> >  ##
>> > -{ 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'failed', 'nospace' ] }
>> > +{ 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'nospace', 'failed' ] }
> Isn't this an ABI change?  Do we have any generated or client code where
> 'failed' mapping to 1 (pre-patch) vs. 2 (post-patch) would cause us
> back-compat grief?

No, we do not generate any code (yet?) for consumption outside QEMU
itself.  In particular we do not install any generated header nor do we
use the generated enums in a (static or shared) library.

Paolo