From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SozXG-0006mT-Gw
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:13:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SozXD-0007SY-Mh
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:13:06 -0400
Received: from mail-gg0-f173.google.com ([209.85.161.173]:51774)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SozXD-0007SS-Et
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:13:03 -0400
Received: by ggnp1 with SMTP id p1so1489791ggn.4
	for <qemu-devel@nongnu.org>; Wed, 11 Jul 2012 09:13:01 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FFDA607.3080301@redhat.com>
Date: Wed, 11 Jul 2012 18:12:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com>
	<1339772759-31004-15-git-send-email-pbonzini@redhat.com>
	<4FDB77CF.8000906@redhat.com>
In-Reply-To: <4FDB77CF.8000906@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 14/36] stream: add on_error argument
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com, lcapitulino@redhat.com

Il 15/06/2012 19:58, Eric Blake ha scritto:
> On 06/15/2012 09:05 AM, Paolo Bonzini wrote:
>> This patch adds support for error management to streaming.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  block/stream.c   |   28 +++++++++++++++++++++++++++-
>>  block_int.h      |    3 ++-
>>  blockdev.c       |   11 ++++++++---
>>  hmp.c            |    3 ++-
>>  qapi-schema.json |    9 ++++++---
>>  qmp-commands.hx  |    2 +-
>>  6 files changed, 46 insertions(+), 10 deletions(-)
>>
> 
>> +++ b/qapi-schema.json
>> @@ -1650,6 +1650,8 @@
>>  #
>>  # @speed:  #optional the maximum speed, in bytes per second
>>  #
>> +# @on_error: #optional the action to take on an error (default report)
>> +#
>>  # Returns: Nothing on success
>>  #          If streaming is already active on this device, DeviceInUse
>>  #          If @device does not exist, DeviceNotFound
>> @@ -1657,10 +1659,11 @@
>>  #          If @base does not exist, BaseNotFound
>>  #          If @speed is invalid, InvalidParameter
> 
> Should you mention the possibility of the new
> QERR_INVALID_PARAMETER_COMBINATION error when on_error requests an
> action that the device doesn't support?

Yes, but I'll just change it to InvalidParameter.

>>  #
>> -# Since: 1.1
>> +# Since: 1.1, on_error since 1.2
> 
> First instance of a double since.  I like the idea; should we be using
> it in more places?

Yes, but I'll move the "since" to the description of on_error.