From: Paolo Bonzini <pbonzini@redhat.com>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] SCSI: improve the lba-out-of-range tests for read/write/verify
Date: Thu, 12 Jul 2012 09:15:45 +0200 [thread overview]
Message-ID: <4FFE79A1.7010203@redhat.com> (raw)
In-Reply-To: <CAN05THTu+3kALTgROah8bFM=8miwm6j-BOrOS2WV6+y_qEiGcw@mail.gmail.com>
Il 12/07/2012 09:06, ronnie sahlberg ha scritto:
> Sorry, there is a bug in it.
>
> Can you change it to :
> || r->req.cmd.lba + len > s->qdev.max_lba + 1) {
>
> or else the last lba of the device will be flagged as out of range.
Yes, done that already. Can you add a test for the last LBA to your
testsuite?
Paolo
prev parent reply other threads:[~2012-07-12 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 6:52 [Qemu-devel] [PATCH] SCSI improved LBA-out-of-range checks Ronnie Sahlberg
2012-07-12 6:52 ` [Qemu-devel] [PATCH] SCSI: improve the lba-out-of-range tests for read/write/verify Ronnie Sahlberg
2012-07-12 7:04 ` Paolo Bonzini
2012-07-12 7:06 ` ronnie sahlberg
2012-07-12 7:15 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFE79A1.7010203@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).