From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpDcx-0004g8-Vx for qemu-devel@nongnu.org; Thu, 12 Jul 2012 03:16:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SpDcs-0001ug-96 for qemu-devel@nongnu.org; Thu, 12 Jul 2012 03:15:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpDcs-0001uQ-0G for qemu-devel@nongnu.org; Thu, 12 Jul 2012 03:15:50 -0400 Message-ID: <4FFE79A1.7010203@redhat.com> Date: Thu, 12 Jul 2012 09:15:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1342075967-26378-1-git-send-email-ronniesahlberg@gmail.com> <1342075967-26378-2-git-send-email-ronniesahlberg@gmail.com> <4FFE771A.7030503@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] SCSI: improve the lba-out-of-range tests for read/write/verify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ronnie sahlberg Cc: qemu-devel@nongnu.org Il 12/07/2012 09:06, ronnie sahlberg ha scritto: > Sorry, there is a bug in it. > > Can you change it to : > || r->req.cmd.lba + len > s->qdev.max_lba + 1) { > > or else the last lba of the device will be flagged as out of range. Yes, done that already. Can you add a test for the last LBA to your testsuite? Paolo