From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpFIl-0004IY-OE for qemu-devel@nongnu.org; Thu, 12 Jul 2012 05:03:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SpFIW-0005ko-Np for qemu-devel@nongnu.org; Thu, 12 Jul 2012 05:03:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpFIW-0005kM-G2 for qemu-devel@nongnu.org; Thu, 12 Jul 2012 05:02:56 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6C92tMD005601 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 12 Jul 2012 05:02:55 -0400 Message-ID: <4FFE92BD.6040000@redhat.com> Date: Thu, 12 Jul 2012 11:02:53 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1342012119-27088-1-git-send-email-armbru@redhat.com> In-Reply-To: <1342012119-27088-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] Cleanups around hw/block-common.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org Am 11.07.2012 15:08, schrieb Markus Armbruster: > Applies on top of "[PATCH v3 00/29] Disk geometry cleanup". > > Markus Armbruster (4): > hw/block-common: Move BlockConf & friends from block.h > hw/block-common: Factor out fall back to legacy -drive serial=... > blockdev: Don't limit DriveInfo serial to 20 characters > hw/block-common: Factor out fall back to legacy -drive cyls=... > > block.h | 45 ----------------------------------- > blockdev.c | 4 +-- > blockdev.h | 4 +-- > hw/Makefile.objs | 2 +- > hw/block-common.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++ > hw/block-common.h | 50 +++++++++++++++++++++++++++++++++++++++ > hw/ide/core.c | 30 +++++++++++----------- > hw/ide/internal.h | 1 + > hw/ide/qdev.c | 31 +++--------------------- > hw/scsi-disk.c | 37 ++-------------------------- > hw/scsi.h | 1 + > hw/usb.h | 1 - > hw/usb/dev-storage.c | 10 +------ > hw/virtio-blk.c | 37 ++-------------------------- > hw/virtio-blk.h | 2 +- > hw/virtio.h | 1 - > 16 files changed, 147 insertions(+), 173 deletions(-) > create mode 100644 hw/block-common.c > Thanks, applied all to the block branch. Kevin