From: Eric Blake <eblake@redhat.com>
To: Pavel Hrdina <phrdina@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 3/4] qapi: Convert delvm
Date: Thu, 12 Jul 2012 11:59:11 -0600 [thread overview]
Message-ID: <4FFF106F.5070603@redhat.com> (raw)
In-Reply-To: <049abd55f3f85bac5d299ca34f17b9abd39fedc4.1342092497.git.phrdina@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On 07/12/2012 10:55 AM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
> hmp-commands.hx | 2 +-
> hmp.c | 10 ++++++++++
> hmp.h | 1 +
> qapi-schema.json | 17 +++++++++++++++++
> qmp-commands.hx | 24 ++++++++++++++++++++++++
> savevm.c | 21 +++++++++++----------
> sysemu.h | 1 -
> 7 files changed, 64 insertions(+), 12 deletions(-)
> +
> +##
> +# @delvm:
This name is worse than 'loadvm' or 'savevm', in that we are NOT
deleting the entire vm, but a named snapshot stored within the vm.
Would naming it 'delete-vm-snapshot' make more sense (in which case the
others might make more sense as 'save-vm-snapshot' and 'load-vm-snapshot')?
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-07-12 17:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 16:55 [Qemu-devel] [RFC PATCH 0/4] qapi: Convert snapshot's commands Pavel Hrdina
2012-07-12 16:55 ` [Qemu-devel] [RFC PATCH 1/4] qapi: Convert savevm Pavel Hrdina
2012-07-12 17:53 ` Eric Blake
2012-07-16 8:12 ` Pavel Hrdina
2012-07-23 20:41 ` Luiz Capitulino
2012-07-23 20:41 ` Luiz Capitulino
2012-07-12 16:55 ` [Qemu-devel] [RFC PATCH 2/4] qapi: Convert loadvm Pavel Hrdina
2012-07-12 17:56 ` Eric Blake
2012-07-24 17:04 ` Luiz Capitulino
2012-07-24 17:03 ` Luiz Capitulino
2012-07-12 16:55 ` [Qemu-devel] [RFC PATCH 3/4] qapi: Convert delvm Pavel Hrdina
2012-07-12 17:59 ` Eric Blake [this message]
2012-07-16 8:12 ` Pavel Hrdina
2012-07-16 16:37 ` Eric Blake
2012-07-17 10:55 ` Kevin Wolf
2012-07-12 16:55 ` [Qemu-devel] [RFC PATCH 4/4] qapi: Convert info snapshots Pavel Hrdina
2012-07-12 18:03 ` Eric Blake
2012-07-16 8:15 ` Pavel Hrdina
2012-07-24 17:30 ` [Qemu-devel] [RFC PATCH 0/4] qapi: Convert snapshot's commands Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFF106F.5070603@redhat.com \
--to=eblake@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).