From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SparT-0004tR-JP for qemu-devel@nongnu.org; Fri, 13 Jul 2012 04:04:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SparS-0006U2-A8 for qemu-devel@nongnu.org; Fri, 13 Jul 2012 04:04:27 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:59539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SparS-0006Tu-3w for qemu-devel@nongnu.org; Fri, 13 Jul 2012 04:04:26 -0400 Received: by pbbro12 with SMTP id ro12so5350388pbb.4 for ; Fri, 13 Jul 2012 01:04:25 -0700 (PDT) Message-ID: <4FFFD682.4000507@ozlabs.ru> Date: Fri, 13 Jul 2012 18:04:18 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1341927973-5615-1-git-send-email-aik@ozlabs.ru> <1341927973-5615-5-git-send-email-aik@ozlabs.ru> In-Reply-To: <1341927973-5615-5-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] xics: added end-of-interrupt (EOI) handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, Jan Kiszka , qemu-ppc@nongnu.org, Alexander Graf , David Gibson Already outdated :) On 10/07/12 23:46, Alexey Kardashevskiy wrote: > Normally when the host driver gets called via interrupt, it disables IRQ > first, then handles it and enables back. In the case of PCI pass through, > the actual handling is done by the guest so the host driver needs to know > when to enable IRQ back. > > The patch introduces add/remove callback API and EOI initialization for > the XICS interrupt controller. > > Signed-off-by: Alexey Kardashevskiy > --- > hw/xics.c | 18 ++++++++++++++++++ > hw/xics.h | 5 +++++ > 2 files changed, 23 insertions(+) > > diff --git a/hw/xics.c b/hw/xics.c > index 668a0d6..de7833e 100644 > --- a/hw/xics.c > +++ b/hw/xics.c > @@ -170,6 +170,7 @@ struct ics_irq_state { > int sent:1; > int rejected:1; > int masked_pending:1; > + NotifierList eoi_notifier; > }; > > struct ics_state { > @@ -309,6 +310,8 @@ static void ics_eoi(struct ics_state *ics, int nr) > if (irq->type == XICS_LSI) { > irq->sent = 0; > } > + > + notifier_list_notify(&irq->eoi_notifier, NULL); > } > > /* > @@ -536,6 +539,7 @@ struct icp_state *xics_system_init(int nr_irqs) > for (i = 0; i < nr_irqs; i++) { > ics->irqs[i].priority = 0xff; > ics->irqs[i].saved_priority = 0xff; > + notifier_list_init(&ics->irqs[i].eoi_notifier); > } > > ics->qirqs = qemu_allocate_irqs(ics_set_irq, ics, nr_irqs); > @@ -552,3 +556,17 @@ struct icp_state *xics_system_init(int nr_irqs) > > return icp; > } > + > +void xics_add_eoi_notifier(Notifier *notify, uint32_t srcno) > +{ > + struct ics_state *ics = spapr->icp->ics; > + struct ics_irq_state *irq = &ics->irqs[srcno - ics->offset]; > + > + notifier_list_add(&irq->eoi_notifier, notify); > +} > + > +void xics_remove_eoi_notifier(Notifier *notify) > +{ > + notifier_remove(notify); > +} > + > diff --git a/hw/xics.h b/hw/xics.h > index 2080159..762243c 100644 > --- a/hw/xics.h > +++ b/hw/xics.h > @@ -27,6 +27,8 @@ > #if !defined(__XICS_H__) > #define __XICS_H__ > > +#include "notify.h" > + > #define XICS_IPI 0x2 > > struct icp_state; > @@ -41,4 +43,7 @@ qemu_irq xics_assign_irq(struct icp_state *icp, int irq, > > struct icp_state *xics_system_init(int nr_irqs); > > +void xics_add_eoi_notifier(Notifier *notify, uint32_t srcno); > +void xics_remove_eoi_notifier(Notifier *notify); > + > #endif /* __XICS_H__ */ > -- Alexey