From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpbMp-000275-Ux for qemu-devel@nongnu.org; Fri, 13 Jul 2012 04:37:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SpbMj-0006KX-Kd for qemu-devel@nongnu.org; Fri, 13 Jul 2012 04:36:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpbMj-0006KQ-CH for qemu-devel@nongnu.org; Fri, 13 Jul 2012 04:36:45 -0400 Message-ID: <4FFFDE18.6090004@redhat.com> Date: Fri, 13 Jul 2012 10:36:40 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1342103249-20888-1-git-send-email-kwolf@redhat.com> <1342103249-20888-2-git-send-email-kwolf@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] coroutine-ucontext: Help valgrind understand coroutines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org Am 12.07.2012 19:14, schrieb Peter Maydell: > On 12 July 2012 15:27, Kevin Wolf wrote: >> valgrind tends to get confused and report false positives when you >> switch stacks and don't tell it about it. > > Does the sigaltstack backend need anything similar? Don't know, I never used valgrind with sigaltstack coroutines. All examples that I found for the stack registration functions were using it in the context of ucontext, but I wouldn't be surprised if sigaltstack needs it as well. If you care enough, you can try it out and send a patch, otherwise we can still add it when someone needs it. Kevin