From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Gavin Shan <gshan@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH-for-9.0 03/16] target/arm/kvm: Have kvm_arm_add_vcpu_properties take a ARMCPU argument
Date: Tue, 28 Nov 2023 07:52:55 +0100 [thread overview]
Message-ID: <4a04694e-f376-406f-84cb-f677ded08988@linaro.org> (raw)
In-Reply-To: <52cf8040-b134-4dc6-b6ce-1d51a3dc13ef@redhat.com>
On 27/11/23 05:05, Gavin Shan wrote:
> Hi Phil,
>
> On 11/24/23 05:35, Philippe Mathieu-Daudé wrote:
>> Unify the "kvm_arm.h" API: All functions related to ARM vCPUs
>> take a ARMCPU* argument. Use the CPU() QOM cast macro When
>> calling the generic vCPU API from "sysemu/kvm.h".
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> target/arm/kvm_arm.h | 4 ++--
>> target/arm/cpu.c | 2 +-
>> target/arm/kvm.c | 4 ++--
>> 3 files changed, 5 insertions(+), 5 deletions(-)
>>
>
> With the following comments resolved:
>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
>
>> diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h
>> index 50967f4ae9..6fb8a5f67e 100644
>> --- a/target/arm/kvm_arm.h
>> +++ b/target/arm/kvm_arm.h
>> @@ -153,7 +153,7 @@ void kvm_arm_set_cpu_features_from_host(ARMCPU *cpu);
>> * Add all KVM specific CPU properties to the CPU object. These
>> * are the CPU properties with "kvm-" prefixed names.
>> */
>> -void kvm_arm_add_vcpu_properties(Object *obj);
>> +void kvm_arm_add_vcpu_properties(ARMCPU *cpu);
>
> The function's description needs to be modified since @obj has been
> renamed to @cpu?
>
> /**
> * kvm_arm_add_vcpu_properties:
> * @obj: The CPU object to add the properties to
> *
> */
Oops thanks!
next prev parent reply other threads:[~2023-11-28 6:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 18:35 [PATCH-for-9.0 00/16] target/arm/kvm: Unify kvm_arm_FOO() API Philippe Mathieu-Daudé
2023-11-23 18:35 ` [PATCH-for-9.0 01/16] hw/intc/arm_gicv3: Include missing 'qemu/error-report.h' header Philippe Mathieu-Daudé
2023-11-27 3:54 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 02/16] target/arm/kvm: Remove unused includes Philippe Mathieu-Daudé
2023-11-27 3:59 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 03/16] target/arm/kvm: Have kvm_arm_add_vcpu_properties take a ARMCPU argument Philippe Mathieu-Daudé
2023-11-27 4:05 ` Gavin Shan
2023-11-28 6:52 ` Philippe Mathieu-Daudé [this message]
2023-11-23 18:35 ` [PATCH-for-9.0 04/16] target/arm/kvm: Have kvm_arm_sve_set_vls " Philippe Mathieu-Daudé
2023-11-27 4:07 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 05/16] target/arm/kvm: Have kvm_arm_sve_get_vls " Philippe Mathieu-Daudé
2023-11-27 4:12 ` Gavin Shan
2023-11-28 6:52 ` Philippe Mathieu-Daudé
2023-11-23 18:35 ` [PATCH-for-9.0 06/16] target/arm/kvm: Have kvm_arm_set_device_attr " Philippe Mathieu-Daudé
2023-11-27 4:13 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 07/16] target/arm/kvm: Have kvm_arm_pvtime_init " Philippe Mathieu-Daudé
2023-11-27 4:15 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 08/16] target/arm/kvm: Have kvm_arm_pmu_init " Philippe Mathieu-Daudé
2023-11-27 4:20 ` Gavin Shan
2023-11-28 6:46 ` Philippe Mathieu-Daudé
2023-11-23 18:35 ` [PATCH-for-9.0 09/16] target/arm/kvm: Have kvm_arm_pmu_set_irq " Philippe Mathieu-Daudé
2023-11-27 4:21 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 10/16] target/arm/kvm: Have kvm_arm_vcpu_init " Philippe Mathieu-Daudé
2023-11-27 4:24 ` Gavin Shan
2023-11-27 4:25 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 11/16] target/arm/kvm: Have kvm_arm_vcpu_finalize " Philippe Mathieu-Daudé
2023-11-27 4:26 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 12/16] target/arm/kvm: Have kvm_arm_[get|put]_virtual_time take " Philippe Mathieu-Daudé
2023-11-27 4:29 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 13/16] target/arm/kvm: Have kvm_arm_verify_ext_dabt_pending take a ARMCPU arg Philippe Mathieu-Daudé
2023-11-27 4:31 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 14/16] target/arm/kvm: Have kvm_arm_handle_dabt_nisv take a ARMCPU argument Philippe Mathieu-Daudé
2023-11-27 4:33 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 15/16] target/arm/kvm: Have kvm_arm_handle_debug " Philippe Mathieu-Daudé
2023-11-27 4:34 ` Gavin Shan
2023-11-23 18:35 ` [PATCH-for-9.0 16/16] target/arm/kvm: Have kvm_arm_hw_debug_active " Philippe Mathieu-Daudé
2023-11-27 4:36 ` Gavin Shan
2023-11-26 13:59 ` [PATCH-for-9.0 00/16] target/arm/kvm: Unify kvm_arm_FOO() API Richard Henderson
2023-12-11 14:36 ` Peter Maydell
2023-12-13 9:42 ` Philippe Mathieu-Daudé
2023-12-14 15:34 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a04694e-f376-406f-84cb-f677ded08988@linaro.org \
--to=philmd@linaro.org \
--cc=gshan@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).