qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Christophe de Dinechin <dinechin@redhat.com>, r.bolshakov@yadro.com
Subject: Re: [PATCH] configure: move cocoa option to Meson
Date: Wed, 16 Sep 2020 08:30:22 -0700	[thread overview]
Message-ID: <4a101a38-cf97-f155-9b89-cfd70a35fe8b@linaro.org> (raw)
In-Reply-To: <20200916081131.21775-1-pbonzini@redhat.com>

On 9/16/20 1:11 AM, Paolo Bonzini wrote:
>    --enable-cocoa)
> -      cocoa="yes" ;
> +      cocoa="enabled" ;

Lose the stray ; at the same time?

> @@ -101,7 +101,7 @@ if targetos == 'windows'
>  elif targetos == 'darwin'
>    coref = dependency('appleframeworks', modules: 'CoreFoundation')
>    iokit = dependency('appleframeworks', modules: 'IOKit')
> -  cocoa = dependency('appleframeworks', modules: 'Cocoa')
> +  cocoa = dependency('appleframeworks', modules: 'Cocoa', required: get_option('cocoa'))
>    hvf = dependency('appleframeworks', modules: 'Hypervisor')
>  elif targetos == 'sunos'
>    socket = [cc.find_library('socket'),
> @@ -112,6 +112,11 @@ elif targetos == 'haiku'
>              cc.find_library('network'),
>              cc.find_library('bsd')]
>  endif
> +
> +if not cocoa.found() and get_option('cocoa').enabled()
> +  error('Cocoa not available on this platform')
> +endif

Isn't the error redundant with the required above?


r~


  reply	other threads:[~2020-09-16 15:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16  8:11 [PATCH] configure: move cocoa option to Meson Paolo Bonzini
2020-09-16 15:30 ` Richard Henderson [this message]
2020-09-16 16:20   ` Richard Henderson
2020-09-18 11:54 ` Roman Bolshakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a101a38-cf97-f155-9b89-cfd70a35fe8b@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=dinechin@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).