From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6001EC433E0 for ; Mon, 11 Jan 2021 12:16:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAF4A20BED for ; Mon, 11 Jan 2021 12:16:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAF4A20BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyw7a-0004U9-SG for qemu-devel@archiver.kernel.org; Mon, 11 Jan 2021 07:16:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyw6L-0003wG-RI for qemu-devel@nongnu.org; Mon, 11 Jan 2021 07:15:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kyw6J-0004ZS-9u for qemu-devel@nongnu.org; Mon, 11 Jan 2021 07:15:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610367310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LJ+vZhptz1ikdT8UclAF8bDp/s03xHYEm3ipT2DdnQc=; b=Y4vNREAjdShYNC3ujKW1aGc7W1ISpg5EIyuGEnQRotcZnHSFBd+vdnb0RoToaIjH2STBKh 6OePNo+OCqgxsUo8NVAOtDcymrvIIOExJBUWr3bnbsunVBlc660XCgWIlOual8XSVH7ZwT pOGvmqjNG/AvnI4QnS6FF/FwfREod+0= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-xxE1OX5-NxaVYl6Wg74dsA-1; Mon, 11 Jan 2021 07:15:08 -0500 X-MC-Unique: xxE1OX5-NxaVYl6Wg74dsA-1 Received: by mail-ed1-f71.google.com with SMTP id e11so8188741edn.11 for ; Mon, 11 Jan 2021 04:15:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LJ+vZhptz1ikdT8UclAF8bDp/s03xHYEm3ipT2DdnQc=; b=K9I6iZZ8rC8RLlTgdW3Decs2SOruU17DO6fSpS9m6Io8uCXlKop+189F6CN7AxhfVB JftZK13bIwqK2ZjB8bVIlfr28AO80NS804G5t8/AR+fWgxYAzW/RJNk8a4YFpKYMvYEq kRbBb9hk2z1XWv8Q18HlGbwdHDsfJ2sIra+cQpETcVzszH9jdfjAwVMsSf7Au6Xk99xZ IL198jAbJABtzmkBUk7vyeU0KuE0who9LdyEcnGhy655+ABmGOiLKaoDnDqaHmfpZsbb w+wmcOHTIoNVNo+wQiLvL2uih+lCWjTGId0uN4N5FT+FwBbftEw5WHBnBlrnlRe1AwcI x9Zg== X-Gm-Message-State: AOAM531SCfF5RQKDrWOreqPxEhtMP0wjFr0qISuqw08SAL+4oIQPBjcU IhmolgeJqahlUDpVYgm+qKq2EFiZ0G6+MWmpnQsPh7mrKHeSsyCXZXQ26SJQQjDK8dfxfgy8jr7 Zmfb7QQskNJ00wec= X-Received: by 2002:a17:906:ce21:: with SMTP id sd1mr10350623ejb.396.1610367307216; Mon, 11 Jan 2021 04:15:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2GXUVHZxqbgWiPGWX6HQz2JZQ5btwVS/9zgKMjwi59rRYtQw6pzeIYHlhAeTS8MDqWzjkjQ== X-Received: by 2002:a17:906:ce21:: with SMTP id sd1mr10350614ejb.396.1610367307010; Mon, 11 Jan 2021 04:15:07 -0800 (PST) Received: from [192.168.1.36] (129.red-88-21-205.staticip.rima-tde.net. [88.21.205.129]) by smtp.gmail.com with ESMTPSA id z24sm7625240edr.9.2021.01.11.04.15.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jan 2021 04:15:06 -0800 (PST) Subject: Re: [RHEL7 qemu-kvm PATCH 3/3] Fix tcg_out_op argument mismatch warning To: mrezanin@redhat.com, qemu-devel@nongnu.org References: <96033fbea8ab38a769c0ac9c23a217b4b5d32864.1610364304.git.mrezanin@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <4a1d82cd-6e18-8a68-ada7-c5f7b66d94d7@redhat.com> Date: Mon, 11 Jan 2021 13:15:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <96033fbea8ab38a769c0ac9c23a217b4b5d32864.1610364304.git.mrezanin@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/11/21 12:30 PM, mrezanin@redhat.com wrote: > From: Miroslav Rezanina > > There's prototype mismatch between tcg/tcg.c and tcg/aarch/tcg-target.c.inc: > > tcg.c: > > static void tcg_out_op(TCGContext *s, TCGOpcode opc, const TCGArg *args, > const int *const_args); > > tcg-target.c.inc: > > static void tcg_out_op(TCGContext *s, TCGOpcode opc, > const TCGArg args[TCG_MAX_OP_ARGS], > const int const_args[TCG_MAX_OP_ARGS]) > > This missmatch cause warnings on GCC 11: > > tcg/aarch64/tcg-target.c.inc:1855:37: error: argument 3 of type 'const TCGArg[16]' {aka 'const long unsigned int[16]'} with mismatched bound [-Werror=array-parameter=] > tcg/aarch64/tcg-target.c.inc:1856:34: error: argument 4 of type 'const int[16]' with mismatched bound [-Werror=array-parameter=] TIL. Interesting, compilers are getting smarter :) > Only architectures with this definition are aarch and sparc. Fixing both archs to use > proper argument type. > --- > tcg/aarch64/tcg-target.c.inc | 3 +-- > tcg/sparc/tcg-target.c.inc | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc > index 26f71cb599..fe6bdbf721 100644 > --- a/tcg/aarch64/tcg-target.c.inc > +++ b/tcg/aarch64/tcg-target.c.inc > @@ -1852,8 +1852,7 @@ static void tcg_out_qemu_st(TCGContext *s, TCGReg data_reg, TCGReg addr_reg, > static tcg_insn_unit *tb_ret_addr; > > static void tcg_out_op(TCGContext *s, TCGOpcode opc, > - const TCGArg args[TCG_MAX_OP_ARGS], > - const int const_args[TCG_MAX_OP_ARGS]) > + const TCGArg *args, const int *const_args) Doing this way we loose information (that the array pointed has TCG_MAX_OP_ARGS elements). What about letting this prototype and fix the other uses? > { > /* 99% of the time, we can signal the use of extension registers > by looking to see if the opcode handles 64-bit data. */ > diff --git a/tcg/sparc/tcg-target.c.inc b/tcg/sparc/tcg-target.c.inc > index 6775bd30fc..976f0f05af 100644 > --- a/tcg/sparc/tcg-target.c.inc > +++ b/tcg/sparc/tcg-target.c.inc > @@ -1294,8 +1294,7 @@ static void tcg_out_qemu_st(TCGContext *s, TCGReg data, TCGReg addr, > } > > static void tcg_out_op(TCGContext *s, TCGOpcode opc, > - const TCGArg args[TCG_MAX_OP_ARGS], > - const int const_args[TCG_MAX_OP_ARGS]) > + const TCGArg *args, const int *const_args) > { > TCGArg a0, a1, a2; > int c, c2; >