From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckpJk-0002wT-T8 for qemu-devel@nongnu.org; Mon, 06 Mar 2017 04:52:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckpJg-0004oR-2c for qemu-devel@nongnu.org; Mon, 06 Mar 2017 04:52:36 -0500 References: From: Thomas Huth Message-ID: <4a30ecb4-77d0-795f-bf61-378546a8b034@redhat.com> Date: Mon, 6 Mar 2017 10:52:28 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 13/13] ppc: Add SM501 device in config for ppc and ppcemb targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: BALATON Zoltan , QEMU Developers , QEMU Trivial , Magnus Damm , Aurelien Jarno , "qemu-ppc@nongnu.org" On 06.03.2017 10:47, Peter Maydell wrote: > On 6 March 2017 at 07:00, Thomas Huth wrote: >> Note: In case you respin the series, you might want to add this >> CONFIG_SM501 to ppc64-softmmu.mak, too, since it is a superset of the >> 32-bit config (i.e. it can also emulate the 32-bit embedded chips). > > Yes, definitely do this please. > (Missed this because ARM's 64-bit default config includes the > 32-bit one rather than duplicating its contents.) I guess we could do something like that on ppc, too (and ppc-softmmu.mak should likely include ppcemb-softmmu.mak), but that's something for QEMU 2.10 / 3.0 / whichever version will be next. Thomas