From: John Snow <jsnow@redhat.com>
To: Klaus Jensen <its@irrelevant.dk>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH] nvme: fix NSSRS offset in CAP register
Date: Wed, 23 Oct 2019 11:26:57 -0400 [thread overview]
Message-ID: <4a51bf95-c38b-7fef-9b97-0bec2bd36854@redhat.com> (raw)
In-Reply-To: <20191023073315.446534-1-its@irrelevant.dk>
On 10/23/19 3:33 AM, Klaus Jensen wrote:
> Fix the offset of the NSSRS field the CAP register.
From NVME 1.4, section 3 ("Controller Registers"), subsection 3.1.1
("Offset 0h: CAP – Controller Capabilities") CAP_NSSRS_SHIFT is bit 36,
not 33.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> Reported-by: Javier Gonzalez <javier.gonz@samsung.com>
> ---
> include/block/nvme.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/block/nvme.h b/include/block/nvme.h
> index 3ec8efcc435e..fa15b51c33bb 100644
> --- a/include/block/nvme.h
> +++ b/include/block/nvme.h
> @@ -23,7 +23,7 @@ enum NvmeCapShift {
> CAP_AMS_SHIFT = 17,
> CAP_TO_SHIFT = 24,
> CAP_DSTRD_SHIFT = 32,
> - CAP_NSSRS_SHIFT = 33,
> + CAP_NSSRS_SHIFT = 36,
> CAP_CSS_SHIFT = 37,
> CAP_MPSMIN_SHIFT = 48,
> CAP_MPSMAX_SHIFT = 52,
>
I like updating commit messages with spec references; if it can be
updated that would be nice.
Regardless:
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2019-10-23 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 7:33 [PATCH] nvme: fix NSSRS offset in CAP register Klaus Jensen
2019-10-23 15:26 ` John Snow [this message]
2019-10-23 19:55 ` Klaus Birkelund
2019-10-29 14:12 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a51bf95-c38b-7fef-9b97-0bec2bd36854@redhat.com \
--to=jsnow@redhat.com \
--cc=fam@euphon.net \
--cc=its@irrelevant.dk \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).