qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>
Subject: Re: [PATCH] target/arm: Introduce aarch64_set_svcr
Date: Thu, 12 Jan 2023 11:27:16 +0100	[thread overview]
Message-ID: <4a707a8b-fc19-c7a2-3ee7-935b448c27be@linaro.org> (raw)
In-Reply-To: <20230112004322.161330-1-richard.henderson@linaro.org>

On 12/1/23 01:43, Richard Henderson wrote:
> Unify the two helper_set_pstate_{sm,za} in this function.
> Do not call helper_* functions from svcr_write.
> Cleans up linux-user usage by consolodating logic.
> 
> Cc: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> 
> Fabiano, I expect this to replace much of your
> 
>    [RFC PATCH v2 07/19] target/arm: Move helper_set_pstate_* into cpregs.c
> 
> r~
> ---
>   target/arm/cpu.h              |  2 +-
>   target/arm/helper-sme.h       |  3 +--
>   linux-user/aarch64/cpu_loop.c | 11 ++--------
>   linux-user/aarch64/signal.c   | 13 ++---------
>   target/arm/helper.c           | 41 ++++++++++++++++++++++++++++++++---
>   target/arm/sme_helper.c       | 37 ++-----------------------------
>   target/arm/translate-a64.c    | 19 ++++++----------
>   7 files changed, 53 insertions(+), 73 deletions(-)

Since this patch was a bit too hard to digest at once, I split it
in trivial steps here:
https://lore.kernel.org/qemu-devel/20230112102436.1913-1-philmd@linaro.org/

For whichever version you prefer:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2023-01-12 11:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12  0:43 [PATCH] target/arm: Introduce aarch64_set_svcr Richard Henderson
2023-01-12 10:27 ` Philippe Mathieu-Daudé [this message]
2023-01-12 14:20 ` Fabiano Rosas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a707a8b-fc19-c7a2-3ee7-935b448c27be@linaro.org \
    --to=philmd@linaro.org \
    --cc=farosas@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).