From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUawG-0002Uq-Mx for qemu-devel@nongnu.org; Wed, 05 Dec 2018 12:26:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUawF-0004Xs-HX for qemu-devel@nongnu.org; Wed, 05 Dec 2018 12:26:20 -0500 From: Vladimir Sementsov-Ogievskiy Date: Wed, 5 Dec 2018 17:26:05 +0000 Message-ID: <4a709a5d-eb8c-5bb6-8fb6-46f7037a2990@virtuozzo.com> References: <20181130220344.3350618-1-eblake@redhat.com> <20181130220344.3350618-7-eblake@redhat.com> In-Reply-To: <20181130220344.3350618-7-eblake@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 06/14] nbd/client: Move export name into NBDExportInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , "qemu-devel@nongnu.org" Cc: "jsnow@redhat.com" , "nsoffer@redhat.com" , "rjones@redhat.com" , "qemu-block@nongnu.org" , Kevin Wolf , Max Reitz MDEuMTIuMjAxOCAxOjAzLCBFcmljIEJsYWtlIHdyb3RlOg0KPiBSZWZhY3RvciB0aGUgJ25hbWUn IHBhcmFtZXRlciBvZiBuYmRfcmVjZWl2ZV9uZWdvdGlhdGUoKSBmcm9tDQo+IGJlaW5nIGEgc2Vw YXJhdGUgcGFyYW1ldGVyIGludG8gYmVpbmcgcGFydCBvZiB0aGUgaW4tb3V0ICdpbmZvJy4NCj4g VGhpcyBhbHNvIHNwaWxscyBvdmVyIHRvIGEgc2ltcGxpZmljYXRpb24gb2YgbmJkX29wdF9nbygp Lg0KPiANCj4gVGhlIG1haW4gZHJpdmVyIGZvciB0aGlzIHJlZmFjdG9yaW5nIGlzIHRoYXQgYW4g dXBjb21pbmcgcGF0Y2gNCj4gd291bGQgbGlrZSB0byBhZGQgc3VwcG9ydCB0byBxZW11LW5iZCB0 byBsaXN0IGluZm9ybWF0aW9uIGFib3V0DQo+IGFsbCBleHBvcnRzIGF2YWlsYWJsZSBvbiBhIHNl cnZlciwgd2hlcmUgdGhlIG5hbWUocykgd2lsbCBiZQ0KPiBwcm92aWRlZCBieSB0aGUgc2VydmVy IGluc3RlYWQgb2YgdGhlIGNsaWVudC4gIEJ1dCBhbm90aGVyIGJlbmVmaXQNCj4gaXMgdGhhdCB3 ZSBjYW4gbm93IGFsbG93IHRoZSBjbGllbnQgdG8gZXhwbGljaXRseSBzcGVjaWZ5IHRoZQ0KPiBl bXB0eSBleHBvcnQgbmFtZSAiIiBldmVuIHdoZW4gY29ubmVjdGluZyB0byBhbiBvbGRzdHlsZSBz ZXJ2ZXINCj4gKGV2ZW4gaWYgcWVtdSBpcyBubyBsb25nZXIgc3VjaCBhIHNlcnZlciBhZnRlciBj b21taXQgN2Y3ZGZlMmEpLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogRXJpYyBCbGFrZSA8ZWJsYWtl QHJlZGhhdC5jb20+DQoNClsuLi5dDQoNCj4gQEAgLTg3Nyw4ICs4NzQsOCBAQCBpbnQgbmJkX3Jl Y2VpdmVfbmVnb3RpYXRlKFFJT0NoYW5uZWwgKmlvYywgY29uc3QgY2hhciAqbmFtZSwNCj4gICAg ICAgfSBlbHNlIGlmIChtYWdpYyA9PSBOQkRfQ0xJRU5UX01BR0lDKSB7DQo+ICAgICAgICAgICB1 aW50MzJfdCBvbGRmbGFnczsNCj4gDQo+IC0gICAgICAgIGlmIChuYW1lKSB7DQo+IC0gICAgICAg ICAgICBlcnJvcl9zZXRnKGVycnAsICJTZXJ2ZXIgZG9lcyBub3Qgc3VwcG9ydCBleHBvcnQgbmFt ZXMiKTsNCj4gKyAgICAgICAgaWYgKCppbmZvLT5uYW1lKSB7DQo+ICsgICAgICAgICAgICBlcnJv cl9zZXRnKGVycnAsICJTZXJ2ZXIgZG9lcyBub3Qgc3VwcG9ydCBub24tZW1wdHkgZXhwb3J0IG5h bWVzIik7DQoNCmhtLCBvbGQgbWVzc2FnZSBpcyBhIGJpdCBuZWFyZXIgdG8gbmJkIHNwZWMsIHRo ZSBuZXcgbWF5IGJlIGEgYml0IG1vcmUNCnVuZGVyc3RhbmRhYmxlIGluIGNvbnRleHQgb2YgY3Vy cmVudCBxZW11LW5iZCBoZWxwOg0KIi14LCAtLWV4cG9ydC1uYW1lPU5BTUUgICAgZXhwb3NlIGV4 cG9ydCBieSBuYW1lIChkZWZhdWx0IGlzIGVtcHR5IHN0cmluZykiDQoNCnNvLCBJJ20gT0sgd2l0 aCBlaXRoZXIgb25lLg0KDQo+ICAgICAgICAgICAgICAgZ290byBmYWlsOw0KPiAgICAgICAgICAg fQ0KPiAgICAgICAgICAgaWYgKHRsc2NyZWRzKSB7DQo+IGRpZmYgLS1naXQgYS9xZW11LW5iZC5j IGIvcWVtdS1uYmQuYw0KPiBpbmRleCA4NjZlNjQ3NzlmMS4uYzU3MDUzYTA3OTUgMTAwNjQ0DQo+ IC0tLSBhL3FlbXUtbmJkLmMNCj4gKysrIGIvcWVtdS1uYmQuYw0KPiBAQCAtMjYzLDcgKzI2Myw3 IEBAIHN0YXRpYyB2b2lkICpzaG93X3BhcnRzKHZvaWQgKmFyZykNCj4gICBzdGF0aWMgdm9pZCAq bmJkX2NsaWVudF90aHJlYWQodm9pZCAqYXJnKQ0KPiAgIHsNCj4gICAgICAgY2hhciAqZGV2aWNl ID0gYXJnOw0KPiAtICAgIE5CREV4cG9ydEluZm8gaW5mbyA9IHsgLnJlcXVlc3Rfc2l6ZXMgPSBm YWxzZSwgfTsNCj4gKyAgICBOQkRFeHBvcnRJbmZvIGluZm8gPSB7IC5yZXF1ZXN0X3NpemVzID0g ZmFsc2UsIC5uYW1lID0gZ19zdHJkdXAoIiIpIH07DQo+ICAgICAgIFFJT0NoYW5uZWxTb2NrZXQg KnNpb2M7DQo+ICAgICAgIGludCBmZDsNCj4gICAgICAgaW50IHJldDsNCj4gQEAgLTI3OCw3ICsy NzgsNyBAQCBzdGF0aWMgdm9pZCAqbmJkX2NsaWVudF90aHJlYWQodm9pZCAqYXJnKQ0KPiAgICAg ICAgICAgZ290byBvdXQ7DQo+ICAgICAgIH0NCj4gDQo+IC0gICAgcmV0ID0gbmJkX3JlY2VpdmVf bmVnb3RpYXRlKFFJT19DSEFOTkVMKHNpb2MpLCBOVUxMLA0KPiArICAgIHJldCA9IG5iZF9yZWNl aXZlX25lZ290aWF0ZShRSU9fQ0hBTk5FTChzaW9jKSwNCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIE5VTEwsIE5VTEwsIE5VTEwsICZpbmZvLCAmbG9jYWxfZXJyb3IpOw0KPiAg ICAgICBpZiAocmV0IDwgMCkgew0KPiAgICAgICAgICAgaWYgKGxvY2FsX2Vycm9yKSB7DQo+IEBA IC0zMTcsNiArMzE3LDcgQEAgc3RhdGljIHZvaWQgKm5iZF9jbGllbnRfdGhyZWFkKHZvaWQgKmFy ZykNCj4gICAgICAgfQ0KPiAgICAgICBjbG9zZShmZCk7DQo+ICAgICAgIG9iamVjdF91bnJlZihP QkpFQ1Qoc2lvYykpOw0KPiArICAgIGZyZWUoaW5mby5uYW1lKTsNCg0KZ19mcmVlDQoNCj4gICAg ICAga2lsbChnZXRwaWQoKSwgU0lHVEVSTSk7DQo+ICAgICAgIHJldHVybiAodm9pZCAqKSBFWElU X1NVQ0NFU1M7DQo+IA0KPiBAQCAtMzI1LDYgKzMyNiw3IEBAIG91dF9mZDoNCj4gICBvdXRfc29j a2V0Og0KPiAgICAgICBvYmplY3RfdW5yZWYoT0JKRUNUKHNpb2MpKTsNCj4gICBvdXQ6DQo+ICsg ICAgZnJlZShpbmZvLm5hbWUpOw0KDQphbmQgaGVyZQ0KDQo+ICAgICAgIGtpbGwoZ2V0cGlkKCks IFNJR1RFUk0pOw0KPiAgICAgICByZXR1cm4gKHZvaWQgKikgRVhJVF9GQUlMVVJFOw0KPiAgIH0N Cj4gZGlmZiAtLWdpdCBhL25iZC90cmFjZS1ldmVudHMgYi9uYmQvdHJhY2UtZXZlbnRzDQo+IGlu ZGV4IDVlMWQ0YWZlOGU2Li4yODkzMzdkMGRjMyAxMDA2NDQNCj4gLS0tIGEvbmJkL3RyYWNlLWV2 ZW50cw0KPiArKysgYi9uYmQvdHJhY2UtZXZlbnRzDQo+IEBAIC0xNSw3ICsxNSw3IEBAIG5iZF9v cHRfbWV0YV9yZXBseShjb25zdCBjaGFyICpjb250ZXh0LCB1aW50MzJfdCBpZCkgIlJlY2VpdmVk IG1hcHBpbmcgb2YgY29udGV4DQo+ICAgbmJkX3JlY2VpdmVfbmVnb3RpYXRlKHZvaWQgKnRsc2Ny ZWRzLCBjb25zdCBjaGFyICpob3N0bmFtZSkgIlJlY2VpdmluZyBuZWdvdGlhdGlvbiB0bHNjcmVk cz0lcCBob3N0bmFtZT0lcyINCj4gICBuYmRfcmVjZWl2ZV9uZWdvdGlhdGVfbWFnaWModWludDY0 X3QgbWFnaWMpICJNYWdpYyBpcyAweCUiIFBSSXg2NA0KPiAgIG5iZF9yZWNlaXZlX25lZ290aWF0 ZV9zZXJ2ZXJfZmxhZ3ModWludDMyX3QgZ2xvYmFsZmxhZ3MpICJHbG9iYWwgZmxhZ3MgYXJlIDB4 JSIgUFJJeDMyDQo+IC1uYmRfcmVjZWl2ZV9uZWdvdGlhdGVfZGVmYXVsdF9uYW1lKHZvaWQpICJV c2luZyBkZWZhdWx0IE5CRCBleHBvcnQgbmFtZSBcIlwiIg0KPiArbmJkX3JlY2VpdmVfbmVnb3Rp YXRlX25hbWUoY29uc3QgY2hhciAqbmFtZSkgIlJlcXVlc3RpbmcgTkJEIGV4cG9ydCBuYW1lIFwi JXNcIiINCg0KT3RoZXIgdHJhY2UgcG9pbnRzIHByZWZlcnMgdG8gdXNlIHNpbmdsZSBxdW90ZXMg d2l0aCBleHBvcnQgbmFtZSAob3Igd2l0aG91dCBxdW90ZXMpLA0KdGhpcyBtYXkgYmUgY2hhbmdl ZCB0b28uIE9oLCB0b28gZGVlcCBuaXQtcGlja2luZyBvXzANCg0KPiAgIG5iZF9yZWNlaXZlX25l Z290aWF0ZV9zaXplX2ZsYWdzKHVpbnQ2NF90IHNpemUsIHVpbnQxNl90IGZsYWdzKSAiU2l6ZSBp cyAlIiBQUkl1NjQgIiwgZXhwb3J0IGZsYWdzIDB4JSIgUFJJeDE2DQo+ICAgbmJkX2luaXRfc2V0 X3NvY2tldCh2b2lkKSAiU2V0dGluZyBOQkQgc29ja2V0Ig0KPiAgIG5iZF9pbml0X3NldF9ibG9j a19zaXplKHVuc2lnbmVkIGxvbmcgYmxvY2tfc2l6ZSkgIlNldHRpbmcgYmxvY2sgc2l6ZSB0byAl bHUiDQo+IA0KDQp3aXRoIGZpeGVkIHMvZnJlZS9nX2ZyZWU6DQpSZXZpZXdlZC1ieTogVmxhZGlt aXIgU2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8uY29tPg0KDQoNCi0t IA0KQmVzdCByZWdhcmRzLA0KVmxhZGltaXINCg==