qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Aditya Gupta <adityag@linux.ibm.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] doc: add missing 'Asset' type in function test doc
Date: Thu, 6 Mar 2025 07:44:42 +0100	[thread overview]
Message-ID: <4a96e43a-a4f3-4b24-8ffe-63b5da01f82b@linaro.org> (raw)
In-Reply-To: <20250306060706.1982992-1-adityag@linux.ibm.com>

On 6/3/25 07:07, Aditya Gupta wrote:
> Seems 'Asset' got missed in the documentation by mistake.
> 
> Also fix the one spellcheck issue pointed by spellcheck
> 
> Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>
> ---
>   docs/devel/testing/functional.rst | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/devel/testing/functional.rst b/docs/devel/testing/functional.rst
> index ecc738922b7c..50fca2a0291e 100644
> --- a/docs/devel/testing/functional.rst
> +++ b/docs/devel/testing/functional.rst
> @@ -251,7 +251,7 @@ Many functional tests download assets (e.g. Linux kernels, initrds,
>   firmware images, etc.) from the internet to be able to run tests with
>   them. This imposes additional challenges to the test framework.
>   
> -First there is the the problem that some people might not have an
> +First there is the problem that some people might not have an
>   unconstrained internet connection, so such tests should not be run by
>   default when running ``make check``. To accomplish this situation,
>   the tests that download files should only be added to the "thorough"
> @@ -274,7 +274,9 @@ the tests are run. This pre-caching is done with the qemu_test.Asset
>   class. To use it in your test, declare an asset in your test class with
>   its URL and SHA256 checksum like this::
>   
> -    ASSET_somename = (
> +    from qemu_test import Asset
> +
> +    ASSET_somename = Asset(
>           ('https://www.qemu.org/assets/images/qemu_head_200.png'),
>           '34b74cad46ea28a2966c1d04e102510daf1fd73e6582b6b74523940d5da029dd')
>   

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2025-03-06  6:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06  6:07 [PATCH] doc: add missing 'Asset' type in function test doc Aditya Gupta
2025-03-06  6:44 ` Philippe Mathieu-Daudé [this message]
2025-03-06  7:07   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a96e43a-a4f3-4b24-8ffe-63b5da01f82b@linaro.org \
    --to=philmd@linaro.org \
    --cc=adityag@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).